Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb Android - Profile - Removed avatar did not display semitransparent in offline #10602

Closed
kavimuru opened this issue Aug 26, 2022 · 7 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #10393

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Click on Profile
  4. Click on the avatar edit icon
  5. Click on upload photo
  6. Select any image of your choice>save
  7. Kill the internet connection
  8. Remove the photo

Expected Result:

The deleted avatar should appear semitransparent offline

Actual Result:

Removed avatar did not display semitransparent offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.92-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5705489_Record_2022-08-26-18-20-22.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 26, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro
Copy link
Contributor

@Gonals It seems this should be working after you implemented this. Any idea why the QA passed when @Julesssss tested it but now it's not working?

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2022
@pecanoro pecanoro assigned Gonals and unassigned pecanoro Aug 29, 2022
@pecanoro pecanoro added the Improvement Item broken or needs improvement. label Aug 29, 2022
@Gonals
Copy link
Contributor

Gonals commented Aug 29, 2022

Hmm, not right off the bat. Let me test

@Gonals
Copy link
Contributor

Gonals commented Aug 29, 2022

Ah, wait! This is for the user's profile pic! Mine was for the workspace one! I think the profile one is still in the works.
@jasperhuangg, you were working on this, right?

@Gonals Gonals removed their assignment Aug 29, 2022
@jasperhuangg
Copy link
Contributor

Yep, I'll take a look!

@Julesssss
Copy link
Contributor

Julesssss commented Aug 29, 2022

Mine was for the workspace one! I think the profile one is still in the works.

Yeah, good spot @Gonals, this is a different issue.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Aug 29, 2022

Ah this is actually expected right now because #10235 hasn't been merged or deployed yet. That PR updates the avatar picker on the Profile Page to follow our offline-first practices. You'll notice that this issue happens on all platforms, not just Android mWeb.

Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

5 participants