Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Global Unread Indicator - There is no Global Unread Indicator in Android App #10829

Closed
kbecciv opened this issue Sep 6, 2022 · 6 comments

Comments

@kbecciv
Copy link

kbecciv commented Sep 6, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #10739

Action Performed:

  1. Launch the app
  2. Login with any account (User A), ensure User A is not looking at the chat
  3. Start a chat between User A and User B
  4. Leave a comment on the chat as User B
  5. Leave another comment

Expected Result:

There is Global Unread Indicator in Android App

Actual Result:

There is no Global Unread Indicator in Android App

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.97.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220905-190459_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Interna Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 6, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Sep 6, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2022

Everybody was OOO, so I assigned 10 random eligible people.

@marcaaron marcaaron removed their assignment Sep 6, 2022
@marcaaron
Copy link
Contributor

There isn't an unread indicator in the android app?

@Julesssss
Copy link
Contributor

Yeah, this doesn't sound like a bug. @kbecciv is this issue suggesting that we don't have an unread counter on the app icon like iOS does?

@kbecciv
Copy link
Author

kbecciv commented Sep 6, 2022

@Julesssss @marcaaron Yes, there is no indicator in the Android app. I can check IOS app with build 1.1.96.5 (not update it yet to 1.1.97.2)

@Julesssss
Copy link
Contributor

@Julesssss @marcaaron Yes, there is no indicator in the Android app. I can check IOS app with build 1.1.96.5 (not update it yet to 1.1.97.2)

By 'In the Android app', do you mean while the app is opened, in the List of user chats? Or in the Android OS Home Screen, where you see the app icons? Because if it's the latter then there's no bug here. Android has notification badges, which uses notifications to show a dot on the icon, but the count that iOS has is not supported by Android.

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment