Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS - Workspace - App crashed after back online when adjusted workspace name while offline #10901

Closed
kbecciv opened this issue Sep 8, 2022 · 8 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Sep 8, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #10723

Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Create a workspace while offline
  4. Notice that the default chats are also created and you are still navigated to the workspace settings
  5. Adjust the workspace name while offline and notice that it is updated successfully
  6. Go back online and ensure that everything syncs with the server

Expected Result:

No app crashed after back online when adjusted workspace name while offline

Actual Result:

App crashed after back online when adjusted workspace name while offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.98.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com/Feya86Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

10723.IOS.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Sep 8, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2022

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

What email was used here? We might be able to look at logs more easily with this information so please fill it out.

@kbecciv
Copy link
Author

kbecciv commented Sep 8, 2022

@marcochavezf Updated, credentials used: applausetester+0901abb@applause.expensifail.com/Feya86Katya

@marcaaron
Copy link
Contributor

Not able to reproduce this one locally.

@chiragsalian
Copy link
Contributor

Removing deploy blocker label since we're trying to get #10908 out the door soon.

@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Sep 9, 2022
@marcochavezf
Copy link
Contributor

Probably related to this issue, I'm going to change the priority to daily.

@marcochavezf marcochavezf added Daily KSv2 and removed Hourly KSv2 labels Sep 12, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2022
@marcochavezf
Copy link
Contributor

I'm going to close this issue in favor of #10897, but feel free to re-open it if you think it's a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants