Sign in- Two different warning messages displayed when tap Set Password

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Put you new email address in Sign in page
3. Tap Continue
4. Tap a couple times on Resent Link button
5. Go back to you email and find email from Expensify Concierge
6. Should arrived a several emails due to hitting Resent link several times
7. Tap on first one, which is invalid already
8. Change the link to staging
9. Type password
10. Hit Set Password several times

Expected Result:

One warning messages displayed when tap Set Password several times

Actual Result:

Two different warning messages displayed when tap Set Password several times

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.2.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220919-134812_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sobitneupane]

Proposal:
Reason: Two errors being shown are returned by ErrorUtils.getLatestErrorMessage(this.props.session); (say error1) and ErrorUtils.getLatestErrorMessage(this.props.account); (say error2). When the button is loading, "error1" is undefined. So, during that period, 'error2' is being displayed.

My proposal is to show error message only when button is not loading.

App/src/pages/SetPasswordPage.js

Line 122 in 50d4295

isAlertVisible={!_.isEmpty(error)}

<FormAlertWithSubmitButton
    buttonText={buttonText}
    isLoading={this.props.account.isLoading}
    onSubmit={this.validateAndSubmitForm}
    containerStyles={[styles.mb2, styles.mh0]}
    message={error}
-   isAlertVisible={!_.isEmpty(error)}
+   isAlertVisible={!this.props.account.isLoading && !_.isEmpty(error)}
    isDisabled={!this.state.isFormValid}
/>

Output:

Screen.Recording.2022-09-20.at.12.00.28.mov

[Puneet-here]

cc: @MonilBhavsar

[MonilBhavsar]

Thanks for the ping! Looks like a bug from code refactoring. Looking into it

[MonilBhavsar]

Handling internally as it was caused because of refactoring. The refactor code is deployed and we want to push this fix asap.

[MonilBhavsar]

PR is merged. Waiting for deploy

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mvtglobally]

Issue not reproducible during KI retests. (First week)