Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Green line appears with "New" after request/cancel money #11216

Closed
kbecciv opened this issue Sep 22, 2022 · 15 comments
Closed

Web - Green line appears with "New" after request/cancel money #11216

kbecciv opened this issue Sep 22, 2022 · 15 comments
Labels
Engineering Monthly KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Sep 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Select any user
  4. Click on plus button - Request Money
  5. Select "View" detail and click Cancel

Expected Result:

Green line should not be appear with "New" after request/cancel money

Actual Result:

Green line appears with "New" after request/cancel money

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.5.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1194.mp4

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia & Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662998620350799

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 22, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2022

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bondydaa
Copy link
Contributor

cannot reproduce this on Version 1.2.5-0 (1.2.5-0) with the staging or production server backend.

@bondydaa bondydaa added Weekly KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 22, 2022
@bondydaa bondydaa removed their assignment Sep 22, 2022
@marcaaron
Copy link
Contributor

Gonna add this to my watch list but without a reproduction it's hard to know what is causing this. Probably we will need to capture logs or add more logs if we don't have any ones that can help identify the root cause.

@bondydaa
Copy link
Contributor

oh also confirming I tested directly on staging.new.expensify.com as well and couldn't reproduce either

@kbecciv
Copy link
Author

kbecciv commented Sep 22, 2022

@bondydaa @marcaaron I just check the issue again and noticed that its reproduced for the first attempt to request money .

Recording.1198.mp4

@bondydaa
Copy link
Contributor

hmm strange, i wonder if this is platform specific b/c even testing sending to accounts I've never requested money from i can't reproduce 🤔 very very weird.

@marcaaron
Copy link
Contributor

marcaaron commented Sep 23, 2022

Can we confirm if this testing is happening against the staging API or production API? I also can't reproduce but maybe there is a web change on staging causing this issue.

@melvin-bot
Copy link

melvin-bot bot commented Sep 23, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@bondydaa
Copy link
Contributor

image

ooh boy i just reproduced this! but now I can't again with what I thought was the key...

I think it has to do with switching from a different chat to the 1:1 chat with the person you're requesting money. IIRC I started out with a group chat loaded I think between Nikki and Marc or maybe Marc and Tim and then requested the money and when it switched to the 1:1 chat between me and Nikki to show the IOU the new was there.

Maybe it does need to be the first time you request money from that user and you start with a different chat loaded?

@bondydaa
Copy link
Contributor

though my screenshot suggests otherwise since there are other IOUs shown there and dismissed 🤔

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week) Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants