[HOLD for payment 2022-10-07] [$250] IOS - Chat -Create Group button is hidden than unhidden when tap on field with finger

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with the same expensifail account
3. In app - tap on Fub menu
4. Select New Group
5. Type any email
6. Hold your finger when cursor at the end

Expected Result:

Create Group button should be always visible

Actual Result:

Create Group button is hidden than unhidden when tap on field with finger

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.5.0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5744686_RPReplay_Final1663882355.mp4

Bug5744686_20220922_181930.mp4

Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcochavezf]

Corroborated that's happening on iOS, it's working fine on Android though. Applying the External label.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[aimane-chnaif]

Proposal

RCA:

App/src/pages/NewChatPage.js

Line 213 in f7870e6

<ScreenWrapper keyboardAvoidingViewBehavior="height">

keyboardAvoidingViewBehavior is set to "height" in iOS instead of "padding".

Regressed by #10140 (especially this commit: cc24e69)
@jasperhuangg added this change because of android issue but this is no longer needed because of the following reason:

ScreenWrapper component:
If keyboardAvoidingViewBehavior props is not set, default value is height for android, padding for iOS

Here's similar android issue: #10539
56149b3#diff-dd4bfa50713397aca8cb40145317936ab0affe19abc2a9c24d6c8849ed75dc9bR232

Solution:

-            <ScreenWrapper keyboardAvoidingViewBehavior="height">
+            <ScreenWrapper>

By doing this, android keyboardAvoidingViewBehavior keeps height unchanged and iOS keyboardAvoidingViewBehavior is changed from height to padding

[JmillsExpensify]

Interesting. I'm also able to reproduce. @rushatgabhane what do you think about @aimane-chnaif's proposal above?

[rushatgabhane]

By doing this, android keyboardAvoidingViewBehavior keeps height unchanged and iOS keyboardAvoidingViewBehavior is changed from height to padding

@aimane-chnaif can you please link the code that would verify this? Thanks!

[aimane-chnaif]

@rushatgabhane
ios:

App/src/components/ScreenWrapper/propTypes.js

Line 39 in 6bd5304

keyboardAvoidingViewBehavior: 'padding',

android:

App/src/components/ScreenWrapper/index.android.js

Line 14 in 6bd5304

defaultProps.keyboardAvoidingViewBehavior = 'height';

[rushatgabhane]

Ah okay, thanks!
@marcochavezf I like @aimane-chnaif's proposal.

🎀 👀 🎀C + reviewed

[marcochavezf]

Thank you @rushatgabhane for the review! Assigning @aimane-chnaif 🚀

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @marcochavezf!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "Create Group button is hidden than unhidden when tap on field with finger" #11309

If no regressions arise, payment will be issued on 2022-10-07. 🎊

[JmillsExpensify]

Thanks for the quick work! While we wait for the regression period to pass, @aimane-chnaif and @rushatgabhane, can both of you apply to the Upwork job here: https://www.upwork.com/jobs/~015deb84070d50816b.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[JmillsExpensify]

Hired contributors in the linked job while we wait until the regression period is over.

[JmillsExpensify]

Regression period has passed, so I'm issuing payouts in Upwork for contributors and then I'm closing out this issue.

[JmillsExpensify]

Contributors - payments are out! Let me know if you have any issues or questions.