[HOLD #12603][Image][Performance] Avatar images in a report are re-fetched when we hover on the message

[youssef-lr]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

What performance issue do we need to solve?

We need to figure out why the component re-renders even though nothing changes in the state. This could possibly be due to a parent component re-rendering which makes the child component Avatar re-render as well.

Screen.Recording.2022-09-28.at.03.17.54.mov

What is the impact of this on end-users?

TBD.

List any benchmarks that show the severity of the issue

TBD.

Proposed solution (if any)

TBD.

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

TBD.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[trjExpensify]

👋 @youssef-lr - is this one held on a plan for Image-related feature request and improvements or does it need a volunteer to work on it? CC: @roryabraham

[Beamanator]

Good question, I'd be willing to help look into this if it's not on hold

[roryabraham]

I think this should be on hold for #10894, but that one's up-for-grabs @Beamanator 😉

[trjExpensify]

Go on, @Beamanator. You know you want to.. 😏

Alrighty, I've popped a hold in the title here for now.

[Beamanator]

Interestinggggg I assigned myself to the tracking issue, let's see how this goes :D

[trjExpensify]

You da man! 🏊‍♂️

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

Assigning myself & making weekly for now - still on hold for the main tracking issue

[Beamanator]

Still on hold, making progress on image improvements, see tracking issue

[Beamanator]

Still on hold, will get to this soon hopefully

[Beamanator]

Still holding, downgrading to monthly

[trjExpensify]

No change, server migration comes first then image cashing Melv.

[trjExpensify]

No change yet!

[Beamanator]

same

[trjExpensify]

No change, server migration comes first then image cashing Melv.

[Beamanator]

still held

[trjExpensify]

Still working on web image caching!

[Beamanator]

same ^

[trjExpensify]

In light of #32703 being fixed, the #34505 is in review.

[trjExpensify]

New PRs are in the works and a bit of a wider plan. :)

[trjExpensify]

@youssef-lr @thomas-coldwell @Beamanator with all the performance improvements as of late, I think we took care of this one. I just tried to reproduce on a chat I have with a bunch of attachments/preview components and hovering over them doesn't re-fetch anything in the Network tab.

Going to close this out, but if anyone disagrees, feel free to reopen!