[$250] Connect Bank Account - Connect Manually - "Fix the error" has a pointer cursor but no functionality @varshamb

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Navigate to settings > workspace > connect bank account
3. Connect manually
4. Enter wrong Routing number and other details
5. Check the error message "Please fix the errors in the form before continuing."

Expected Result:

"Fix the error" does not have a pointer cursor and something should happen when you cick on it

Actual Result:

"Fix the error" has a pointer cursor but nothing happens when we click it.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1267.mp4

Expensify/Expensify Issue URL:

Issue reported by: @varshamb

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663725819169889

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[zanyrenney]

Sorry, I am OOO so reassgining.

[Puneet-here]

Hi, We aren't using a function for this right now and this will be implemented after the Form refactors. So I don't think we need this issue.

cc: @luacmartins

[Christinadobrzyn]

Thanks @Puneet-here, we'll close this issue for now

[Luke9389]

I'm going to reopen this issue as it's still happening. We can set it to weekly and check in on reproducibility at that pace. @Puneet-here can you link to the form refactor issue/PR you're referring to?

[aimane-chnaif]

Proposal:

This feature is already implemented here but just typo issue.
props name should be consistent throughout the app.
There are 7 usages of onFixTheErrorsPressed and 6 usages of onFixTheErrorsLinkPressed in the project.
So either use onFixTheErrorsPressed or use onFixTheErrorsLinkPressed throughout the app.

Demo:

demo.mov

[tgolen]

I stumbled upon the problem here. Turns out these prop names do not match.

The code is trying to trigger the callback here:

App/src/components/FormAlertWrapper.js

Line 72 in da9a895

onPress={props.onFixTheErrorsPressed}

(named onFixTheErrorsPressed) but all components are passing a prop named slightly different: onFixTheErrorsLinkPressed

[Luke9389]

Looks like @aimane-chnaif had that one pegged.

@aimane-chnaif are you currently working on a PR for an External issue? If not we can make this one external and assign it to you.

[Christinadobrzyn]

Looks like this is missing the engineering label to determine if it should be external or internal - adding that now!

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aimane-chnaif]

@aimane-chnaif are you currently working on a PR for an External issue? If not we can make this one external and assign it to you.

@Luke9389 no, looking for new issues. I can take this job and create PR instantly. Just to confirm what naming to use consistently: onFixTheErrorsPressed or onFixTheErrorsLinkPressed?

[joekaufmanexpensify]

@varshamb offer sent!

[joekaufmanexpensify]

@parasharrajat offer sent!

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @joekaufmanexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@aimane-chnaif offer sent!

[joekaufmanexpensify]

@parasharrajat Just bumping the offer for this one for whenever you have a sec. Could you accept in Upwork?

[joekaufmanexpensify]

PR has been merged, QA is ongoing.

[parasharrajat]

Will do. Thanks

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "Fix the error" link on form submit #11847

If no regressions arise, payment will be issued on 2022-11-02. 🎊

[joekaufmanexpensify]

Not overdue. Weekly label was just removed. and we should be ready to make payment!

[joekaufmanexpensify]

We're at the 7 day window with no regressions, so issuing payment!

[joekaufmanexpensify]

@aimane-chnaif payment was sent, and contract ended!

[joekaufmanexpensify]

@parasharrajat payment sent and contract ended!

[joekaufmanexpensify]

@varshamb payment sent and contract ended!

[joekaufmanexpensify]

Job closed. This is all set!