-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group - When creating a group/1:1 chat, a message is displayed that the group is not online #11503
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @mountiny ( |
This is definitely caused by this refactoring: #10452 Not sure now why the reportID is not accessible when the report is created as it should be in optimistic |
@iwiznia The create chat/group chat commands are not refactored yet. I assume this should be resolved once these actions are optimistic hence the reportID will always be there and we should not face this issue. Then I would say to remove the deploy blocker and wait for the refactorings to be completed. Stites is working on them now afaik and it should not take too long to complete. |
Started a thread in Slack https://expensify.slack.com/archives/C07J32337/p1664811548821939 |
This is not a deploy blocker as this is a small design issue and it will be resolved by the api refactor done by @stitesExpensify I will put this in hold and assign you @stitesExpensify so you can then close this on out with your API refactor PR https://github.com/Expensify/Expensify/issues/213315 |
Actually I have mentioned this in the appropriate App PR to be part of the testing steps there to make sure this is fixed by those changes. Closing this |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
On hold for https://github.com/Expensify/Expensify/issues/213315
Action Performed:
Expected Result:
No messages should appear on the screen when a new group is created
Actual Result:
When creating a group, a message is displayed that the group is not online
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.11.1
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5757779_Recording__1395.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: