Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group - When creating a group/1:1 chat, a message is displayed that the group is not online #11503

Closed
kbecciv opened this issue Oct 1, 2022 · 7 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


On hold for https://github.com/Expensify/Expensify/issues/213315

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in any account
  3. Click on the green + button
  4. Click on the "New group" option
  5. Select 8 random users from the search list.
  6. Click Crate a Group

Expected Result:

No messages should appear on the screen when a new group is created

Actual Result:

When creating a group, a message is displayed that the group is not online

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.11.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5757779_Recording__1395.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 1, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Oct 1, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2022

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2022

This is definitely caused by this refactoring: #10452

Not sure now why the reportID is not accessible when the report is created as it should be in optimistic

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2022

@iwiznia The create chat/group chat commands are not refactored yet. I assume this should be resolved once these actions are optimistic hence the reportID will always be there and we should not face this issue.

Then I would say to remove the deploy blocker and wait for the refactorings to be completed. Stites is working on them now afaik and it should not take too long to complete.

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2022

@mountiny mountiny added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 4, 2022
@mountiny mountiny changed the title Group - When creating a group/1:1 chat, a message is displayed that the group is not online [HOLD] Group - When creating a group/1:1 chat, a message is displayed that the group is not online Oct 4, 2022
@mountiny
Copy link
Contributor

mountiny commented Oct 4, 2022

This is not a deploy blocker as this is a small design issue and it will be resolved by the api refactor done by @stitesExpensify

I will put this in hold and assign you @stitesExpensify so you can then close this on out with your API refactor PR https://github.com/Expensify/Expensify/issues/213315

@mountiny mountiny added the Improvement Item broken or needs improvement. label Oct 4, 2022
@mountiny mountiny changed the title [HOLD] Group - When creating a group/1:1 chat, a message is displayed that the group is not online [HOLD E/E#213315] Group - When creating a group/1:1 chat, a message is displayed that the group is not online Oct 4, 2022
@mountiny
Copy link
Contributor

mountiny commented Oct 4, 2022

Actually I have mentioned this in the appropriate App PR to be part of the testing steps there to make sure this is fixed by those changes. Closing this

@mountiny mountiny closed this as completed Oct 4, 2022
@mountiny mountiny changed the title [HOLD E/E#213315] Group - When creating a group/1:1 chat, a message is displayed that the group is not online Group - When creating a group/1:1 chat, a message is displayed that the group is not online Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants