Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-07] [N7 Account Settings] Create Contact Method Details page #11575

Closed
Beamanator opened this issue Oct 4, 2022 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Oct 4, 2022

Tracking issue: https://github.com/Expensify/Expensify/issues/182122

Detailed section of doc: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.vwu67pkf1q06

Note: This can only be completed after all API commands in this issue have been created: https://github.com/Expensify/Expensify/issues/231921

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014ac2d7133fe25e10
  • Upwork Job ID: 1625425719555817472
  • Last Price Increase: 2023-02-14
@Beamanator Beamanator added Engineering Weekly KSv2 Improvement Item broken or needs improvement. labels Oct 4, 2022
@Beamanator Beamanator self-assigned this Oct 4, 2022
@Beamanator Beamanator added the Internal Requires API changes or must be handled by Expensify staff label Oct 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2022
@Beamanator
Copy link
Contributor Author

On hold for WhatsApp Quality

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2022
@Beamanator
Copy link
Contributor Author

Still on hold for now, might pick this up next week as discussions from here (#11795) are indicating this could be useful to implement sooner rather than later

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2022
@Beamanator Beamanator removed their assignment Nov 2, 2022
@Beamanator Beamanator removed the Bug Something is broken. Auto assigns a BugZero manager. label Nov 2, 2022
@Beamanator
Copy link
Contributor Author

Unassigning since k2 is not liking that i have so many issues assigned to me on hold, will get back to this once N7 Account Settings if off hold (waiting on #passwordless too probably)

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 28, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@Beamanator
Copy link
Contributor Author

Monthly is fine, still waiting for #passwordless to wrap up

@Beamanator Beamanator changed the title [HOLD] [N7 Account Settings] Create Contact Method Details page [HOLD passwordless] [N7 Account Settings] Create Contact Method Details page Nov 28, 2022
@melvin-bot melvin-bot bot closed this as completed Feb 9, 2023
@MelvinBot
Copy link

@Beamanator, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@Beamanator
Copy link
Contributor Author

No longer on hold for passwordless!

@Beamanator Beamanator changed the title [HOLD passwordless] [N7 Account Settings] Create Contact Method Details page [N7 Account Settings] Create Contact Method Details page Feb 13, 2023
@Beamanator Beamanator added Weekly KSv2 and removed Monthly KSv2 labels Feb 14, 2023
@Beamanator
Copy link
Contributor Author

PR is live and ready for review!

@mollfpr
Copy link
Contributor

mollfpr commented Mar 1, 2023

Thanks, @Beamanator! I will review it after the clarity in the other issue.

@Beamanator
Copy link
Contributor Author

@mollfpr actually if you don't mind reviewing no matter what that would be great - since you're the one who got auto assigned on the PR 😅

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 9, 2023
@melvin-bot melvin-bot bot changed the title [N7 Account Settings] Create Contact Method Details page [HOLD for payment 2023-03-16] [N7 Account Settings] Create Contact Method Details page Mar 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 9, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.80-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-03-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 9, 2023
@Beamanator
Copy link
Contributor Author

FYI the PR for this issue got reverted in this PR (#15761) due to this bug that it caused: #15725

Working on the fix here: #15751

@Beamanator Beamanator removed Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review labels Mar 10, 2023
@Beamanator Beamanator changed the title [HOLD for payment 2023-03-16] [N7 Account Settings] Create Contact Method Details page [N7 Account Settings] Create Contact Method Details page Mar 10, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 10, 2023
@Beamanator
Copy link
Contributor Author

Gunna close this in favor of #15203

@MelvinBot
Copy link

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 31, 2023
@melvin-bot melvin-bot bot changed the title [N7 Account Settings] Create Contact Method Details page [HOLD for payment 2023-04-07] [N7 Account Settings] Create Contact Method Details page Mar 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 31, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@Beamanator
Copy link
Contributor Author

FYI that deploy blocker linked above was from the original PR, not the new one 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants