Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-12-15] [N7 Account Settings] Create Timezone pages #11577

Closed
Beamanator opened this issue Oct 4, 2022 · 10 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Oct 4, 2022

Tracking issue: https://github.com/Expensify/Expensify/issues/182122

Detailed section of doc: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.734gbh8x59o1

Note: This can only be implemented after UpdateAutomaticTimezone and UpdateSelectedTimezone commands have been created (see https://github.com/Expensify/Expensify/issues/238724)

@Beamanator Beamanator added Engineering Weekly KSv2 Improvement Item broken or needs improvement. labels Oct 4, 2022
@Beamanator Beamanator self-assigned this Oct 4, 2022
@Beamanator Beamanator added the Internal Requires API changes or must be handled by Expensify staff label Oct 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2022
@Beamanator
Copy link
Contributor Author

On hold for WhatsApp Quality

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2022
@Beamanator
Copy link
Contributor Author

Still on hold for now, might pick this up next week as discussions from here (#11795) are indicating this could be useful to implement sooner rather than later

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2022
@Beamanator Beamanator removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 26, 2022
@Beamanator Beamanator changed the title [HOLD] [N7 Account Settings] Create Timezone pages [N7 Account Settings] Create Timezone pages Oct 27, 2022
@Beamanator Beamanator mentioned this issue Oct 27, 2022
94 tasks
@Beamanator Beamanator changed the title [N7 Account Settings] Create Timezone pages [HOLD Web-E#35315][N7 Account Settings] Create Timezone pages Nov 1, 2022
@Beamanator Beamanator added the Reviewing Has a PR in review label Nov 1, 2022
@Beamanator Beamanator changed the title [HOLD Web-E#35315][N7 Account Settings] Create Timezone pages [HOLD Web-E#35315] [N7 Account Settings] Create Timezone pages Nov 1, 2022
@Beamanator Beamanator changed the title [HOLD Web-E#35315] [N7 Account Settings] Create Timezone pages [N7 Account Settings] Create Timezone pages Nov 22, 2022
@Beamanator
Copy link
Contributor Author

@cristipaval assigning you too since you're helping getting this PR out the door 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 8, 2022
@melvin-bot melvin-bot bot changed the title [N7 Account Settings] Create Timezone pages [HOLD for payment 2022-12-15] [N7 Account Settings] Create Timezone pages Dec 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-15. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 14, 2022
@Beamanator
Copy link
Contributor Author

Bumped #bugzero for someone to help pay this out

@JmillsExpensify JmillsExpensify self-assigned this Dec 21, 2022
@JmillsExpensify
Copy link

P.S. In the future, just add the Bug label and someone will be automatically assigned. Assigned myself for now.

@JmillsExpensify
Copy link

@rushatgabhane Invited you to the Upwork job here: https://www.upwork.com/jobs/~01a98f332e1bd05d04.

@Beamanator
Copy link
Contributor Author

@JmillsExpensify ok will do, I still feel weird adding Bug on issues that aren't actual bugs, but will do next time - thanks for jumping on this one 👍

@JmillsExpensify
Copy link

Yeah, agreed. It's weird. We should probably streamline this at some point, because it's come up as a recurring point of confusion and ultimately delays payments to contributors. All good though, we can take that convo to bug-zero in Slack.

@JmillsExpensify
Copy link

@rushatgabhane is officially all paid out, so I'm going to close this one out. 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants