[$500] BUG: Copy / Pasting a last message in the compose box, returning the copied text and some random text reported by @mollfpr

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Go to the last chat of a thread
3. Double/triple tap until all the text is highlighted and copy with CMD+C / CTRL+C
4. Paste the text to the composer input or notepad

Expected Result:

The pasted text is the text that you just copy

Actual Result:

The pasted text is the text that you just copy and some random text and error message appears

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.2.16-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/196245398-44c8e0e9-d06d-4dda-ac78-1c2a51465e83.mp4
https://user-images.githubusercontent.com/43996225/196245405-3f3d68f8-2a5f-452f-8dfe-ac9057ccec10.mov

Expensify/Expensify Issue URL:
Issue reported by: @mollfpr
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666000158578689

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[alexpensify]

@kavimuru - I'm unable to replicate this issue. Can you please try again? Thanks!

[mollfpr]

@alexpensify Could you try to send a message and double/triple tap on empty space chat to highlight the text then copy with cmd+c or ctrl+c?

Screen.Recording.2022-10-18.at.09.52.52.mov

[alexpensify]

I'm still unable to replicate it. I followed the new steps to select the white space and input cmd+c and was successful to copy. Assigning it to Engineering for another review.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alexpensify]

Here are screenshots from my test via the web app:

[jasperhuangg]

Can repro on both staging and production; you need to triple-click to highlight the entire message. Going to investigate

[melvin-bot]

Triggered auto assignment to @abekkala (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Current assignee @jasperhuangg is eligible for the External assigner, not assigning anyone new.

[abekkala]

@NikkiWines Can I get your opinion if your GH here would also fix this one?

[abekkala]

confirmed this one is unique and won't fix with that one

[abekkala]

https://www.upwork.com/ab/applicants/1583090429121454080/job-details
https://www.upwork.com/jobs/~0134f44cfb0341e791

[osama256]

PROPOSAL

Replacing copySelectionToClipboard method in src/components/CopySelectionHelper.js with this method :

  import React from 'react';
  import ExpensiMark from 'expensify-common/lib/ExpensiMark';
+ import Str from 'expensify-common/lib/str';

....


    copySelectionToClipboard() {
        const selection = SelectionScraper.getCurrentSelection();
        if (!selection) {
            return;
        }
        const parser = new ExpensiMark();
        if (!Clipboard.canSetHtml()) {
            Clipboard.setString(parser.htmlToMarkdown(selection));
            return;
        }
        if (selection.match(/It's.*Chats/)) {
            const replacement = parser.htmlToMarkdown(selection.split(/It's.*Chats/)[0]);
            Clipboard.setHtml(Str.htmlEncode(replacement), parser.htmlToText(selection).split(/It's.*Chats/)[0]);
            return;
        }
        if (selection.includes('Chats') && selection.includes('Concierge')) {
            const replacement = parser.htmlToMarkdown(selection.split(/Chats/)[0]);
            Clipboard.setHtml(Str.htmlEncode(replacement), parser.htmlToText(selection).split(/Chats/)[0]);
            return;
        }
        Clipboard.setHtml(selection, parser.htmlToText(selection));
    }

webb-2022-10-24_09.16.52.mp4

[trjExpensify]

It can be reliably reproduced on my side on v1.2.23-7. Got a vid Jasper? Are you tapping three times?

[melvin-bot]

@abekkala, @sobitneupane, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@jasperhuangg can you try to replicate again? it seems that @trjExpensify was able to replicate

[jasperhuangg]

@abekkala @trjExpensify sorry missed these notifications, ah I realized I was triple tapping a message with links in it, it only selects everything in the message up to (and not including) the link. The bug won't happen if you do this:

Untitled.mov

To reproduce this you have to use with messages without links (i.e. where triple tapping highlights the entire message). Thanks for reopening and keeping it going!

[jasperhuangg]

^TLDR: we're still looking for proposals for this one!

[trjExpensify]

Yeah, the URL bug is here: #11735

[abekkala]

price doubled to $500
https://www.upwork.com/ab/applicants/1583090429121454080/job-details
https://www.upwork.com/jobs/~0134f44cfb0341e791

[wildan-m]

Proposal

Seems this issue has the same fix with #12028
Please review it:
#12028 (comment)

[abekkala]

@jasperhuangg @sobitneupane
If you approve of the above proposal just give me a quick thumbs ups and I'll start the hiring steps in Upwork

[trjExpensify]

If the fix for this is going to be coming in the same PR as the one for #12028, then we should combine C+ reviewers and issues.

[sobitneupane]

@trjExpensify It is likely that the same PR will solve both the issues.

[melvin-bot]

@abekkala, @sobitneupane, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sobitneupane]

@trjExpensify Should I also review the proposal #12028 (comment) for this issue?

[trjExpensify]

@sobitneupane it looks like @thesahindia has reviewed that proposal and given it the ✅. Though, @thesahindia can you confirm it fixes this issue as well ahead of us closing it?

[thesahindia]

Though, @thesahindia can you confirm it fixes this issue as well ahead of us closing it?

Correct it will be fixed at #12028

[trjExpensify]

Cool! So @mollfpr, for reporting this issue, I've sent you a combined offer on the Upwork job attached to #12028.

@abekkala you can go ahead and close the Upwork job and then this issue. Thanks everyone! 🎉

[abekkala]

Closed Upwork job.

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• @abekkala A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
• @sobitneupane @jasperhuangg The PR that introduced the bug has been identified. Link to the PR:
• @abekkala The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• @abekkala A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• @abekkala Payment has been made to the issue reporter (if applicable)
• @abekkala Payment has been made to the contributor that fixed the issue (if applicable)
• @abekkala Payment has been made to the contributor+ that helped on the issue (if applicable)