Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Reanimated patch #12118

Closed
roryabraham opened this issue Oct 25, 2022 · 6 comments
Closed

Remove Reanimated patch #12118

roryabraham opened this issue Oct 25, 2022 · 6 comments
Assignees
@roryabraham
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review Task

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

This issue is just a reminder to remove the Reanimated patch we've got in this repo whenever:

  • This PR is merged, OR
  • We enable Fabric, making the change in the patch no longer needed

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665437638531509

View all open jobs on GitHub
@roryabraham roryabraham self-assigned this Oct 25, 2022
@roryabraham roryabraham mentioned this issue Oct 25, 2022
Merged
90 tasks
@roryabraham
Copy link
Contributor Author

PR was merged but not yet released

@roryabraham
Copy link
Contributor Author

The PR was released in https://github.com/software-mansion/react-native-reanimated/releases/tag/3.0.0-rc.4, so we can do this at any time

@roryabraham roryabraham mentioned this issue Nov 22, 2022
Closed
98 tasks
@roryabraham
Copy link
Contributor Author

PR up and ready for review: #12921

@roryabraham roryabraham added the Reviewing Has a PR in review label Nov 22, 2022
@dhairyasenjaliya
Copy link
Contributor

hm also here #12152 we are updating Reanimated + Remove patch to fix the error Console error: Warning: RCTBridge required dispatch_sync to load REAModule. This may lead to deadlocks
PR awaiting review: #12817
@roryabraham

@roryabraham
Copy link
Contributor Author

This was done in #12817, just awaiting production deploy

@roryabraham
Copy link
Contributor Author

Deployed to production, closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roryabraham roryabraham

Labels
Engineering Monthly KSv2 Reviewing Has a PR in review Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roryabraham @dhairyasenjaliya