Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for #35011][$250] Chat- "New messages" doesn't jump directly to the message marked as Unread for second time #12249

Open
kbecciv opened this issue Oct 28, 2022 · 57 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12124

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat
  3. Click at Mark as Unread
  4. Click on New Messages button
  5. Clicking "new messages" should jump directly to the message marked as Unread
  6. Scroll to the top of the conversation
  7. Click on New Messages button

Expected Result:

"New messages" should jump directly to the message marked as Unread for second time.

Actual Result:

"New messages" doesn't jump directly to the message marked as Unread for second time

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.2.21.4

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1549.mp4
Screen_Recording_20221028-110232_Chrome.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fec5d287f2840f74
  • Upwork Job ID: 1806803838290439356
  • Last Price Increase: 2024-07-05
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Julesssss
Copy link
Contributor

I'm unable to reproduce this currently, on staging Chrome. However, I think we should keep this open until we can figure out the exact reproducable steps -- but I don't think this should be marked as a regression.

CC @srikarparsi @eVoloshchak -- it seems related to this PR, any idea how to resolve this?

Screen.Recording.2022-10-31.at.11.57.17.mov

@eVoloshchak
Copy link
Contributor

Unable to reproduce this building from the latest sources

Screen.Recording.2022-10-31.at.14.09.58.mov

On the first video from the description looks like the issue is with the list not being loaded completely, you can see the progress bar resizing in the middle of the animation. Not sure about the second video though

@melvin-bot
Copy link

melvin-bot bot commented Nov 1, 2022

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

Bumping to keep Melvin happy.

@srikarparsi, do you have any ideas on this one?

@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2022
@srikarparsi
Copy link
Contributor

srikarparsi commented Nov 2, 2022

I'm also unable to reproduce the issue in staging. I also don't see how the code change would cause an issue like this. @Julesssss Maybe we could close the issue and anyone can reopen it if they're able to reproduce it?

@kbecciv can you check if this is still reproducible?

@kbecciv
Copy link
Author

kbecciv commented Nov 4, 2022

Issue is not reproductible in Web with build 1.2.23.9

Recording.1613.mp4

@srikarparsi
Copy link
Contributor

looks good, thanks @kbecciv. @johncschuster I think we can close this out for now and anyone can reopen if they are able to reproduce.

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2022
@melvin-bot melvin-bot bot removed the Overdue label Nov 7, 2022
@kbecciv
Copy link
Author

kbecciv commented May 25, 2023

QA team is able to reproduce this issue in Android native on build 1.3.18.1

video_41.mp4

@kbecciv kbecciv reopened this May 25, 2023
@melvin-bot melvin-bot bot added the Overdue label May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster johncschuster changed the title Chat- "New messages" doesn't jump directly to the message marked as Unread for second time [Hold #15212] Chat- "New messages" doesn't jump directly to the message marked as Unread for second time May 30, 2023
@johncschuster
Copy link
Contributor

Per this discussion, we're putting this issue on hold.

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2023
@johncschuster johncschuster changed the title [Hold #15212] Chat- "New messages" doesn't jump directly to the message marked as Unread for second time [ON HOLD #15212] Chat- "New messages" doesn't jump directly to the message marked as Unread for second time May 30, 2023
@johncschuster johncschuster changed the title [ON HOLD #15212] Chat- "New messages" doesn't jump directly to the message marked as Unread for second time [HOLD #15212] Chat- "New messages" doesn't jump directly to the message marked as Unread for second time May 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 1, 2023
@johncschuster
Copy link
Contributor

This is on hold, Melvin. Chillax dude.

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@johncschuster
Copy link
Contributor

johncschuster commented Jun 2, 2023

I'm downgrading the label to Weekly while this is on hold.

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@johncschuster
Copy link
Contributor

Still on hold for #35011. Looks like we've got some draft PRs up!

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants