Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve upstream ReactNative android build blocker #12504

Closed
Julesssss opened this issue Nov 7, 2022 · 7 comments
Closed

Resolve upstream ReactNative android build blocker #12504

Julesssss opened this issue Nov 7, 2022 · 7 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Nov 7, 2022

Problem

Facebook broke Android builds last Friday, here's a full breakdown of the cause.

Solution

To fix, we should bump React Native to the latest hotfix release, to resolve an Android build issue that is blocking us from making Android releases.

Manually set the gradle RN version.

@Julesssss Julesssss added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 7, 2022
@Julesssss Julesssss self-assigned this Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Julesssss
Copy link
Contributor Author

This is being handled internally, no need for contributors.

@Julesssss Julesssss added Engineering and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 7, 2022
@Julesssss
Copy link
Contributor Author

Julesssss commented Nov 7, 2022

Okay, so the hotfix is only a few hours old, so the RN-updater and diff table haven't yet been updated.

I assume there are likely no breaking changes, but given that we have previously made changes ourselves, I wonder if it's worth attempting this simple fix in the meantime...

Essentially, we would simply lock our gradle react native version to our current RN version.

@Julesssss
Copy link
Contributor Author

The above fix is even simpler than this, as it doesn't require a React-native bump, or library deploy. I'm going to make this change locally in App and if it works we can discuss next steps.

@Julesssss Julesssss changed the title Bump React Native to 0.70.5 hotfix, unblocking Android failed builds Resolve upstream ReactNative android build blocker Nov 7, 2022
@Julesssss Julesssss added the Reviewing Has a PR in review label Nov 7, 2022
@Julesssss
Copy link
Contributor Author

PR: #12510

@melvin-bot melvin-bot bot closed this as completed Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Julesssss
Copy link
Contributor Author

Applying an additional hermes fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants