Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web shows full offline edit history upon return online #12507

Closed
kavimuru opened this issue Nov 7, 2022 · 4 comments
Closed

Web shows full offline edit history upon return online #12507

kavimuru opened this issue Nov 7, 2022 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Nov 7, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Write a message in any chat
  2. Go offline
  3. Edit the message multiple times
  4. Go back online

Expected Result:

The chat remains as the last version you wrote.

Actual Result:

The chat cycles through all edits that were made

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.24-0
Reproducible in staging?: y
**Reproducible in production?:**y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @dangrous
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667604470708629

2022-11-04_16-21-08.mp4

View all open jobs on GitHub

Recording.859.mp4
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@miljakljajic
Copy link
Contributor

I was able to reproduce this. Assigning an engineer to triage - can this be worked on by an external contributor?

@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg
Copy link
Contributor

@marcaaron and I have already noticed and had a discussion about this error here, for now we've agreed not to do anything.

A solution to this would have to involve modifying the SequentialQueue to merge requests that have the same command. For now we've decided this is not a priority, since the final value that it lands on after cycling through all the values is the correct value that was last set.

Therefore, I'm going to close this out for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants