Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Workspace - Invite new member - 403 error message in console #12637

Closed
kbecciv opened this issue Nov 10, 2022 · 16 comments
Closed

[$250] Workspace - Invite new member - 403 error message in console #12637

kbecciv opened this issue Nov 10, 2022 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Nov 10, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12551

Action Performed:

  1. Launch the app
  2. Login with any account
  3. Go to Settings -> Workspaces -> workspace -> Manage members
  4. Verify that no console error shows
  5. Click Invite button to go to Invite new members page

Expected Result:

Verify that no console error shows

Actual Result:

403 error message displayed in console

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.2.26.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5814510_12551_Desktop.mp4

Screen Shot 2022-11-09 at 5 51 17 PM (1)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 10, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 10, 2022

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@alexpensify
Copy link
Contributor

I see the Console response but I still can invite the user.

image

Assigning to engineering for extra eyes if we need to fix.

@melvin-bot
Copy link

melvin-bot bot commented Nov 11, 2022

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@iwiznia
Copy link
Contributor

iwiznia commented Nov 11, 2022

I can't reproduce this, @kbecciv can you share the full console error message (preferrably as text, since it has a huge URL in it)? The one you shared is truncated.
My guess is that it has something to so with the avatar image...

@iwiznia iwiznia assigned kbecciv and unassigned iwiznia Nov 11, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Nov 11, 2022

Oh, also, @alexpensify can't reproduce either (the console messages there are different than the OG post)

@kbecciv
Copy link
Author

kbecciv commented Nov 14, 2022

@iwiznia Checking, update you shortly

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 14, 2022

@iwiznia Please attach the requested .txt. file for the console error message.

console error.txt

@iwiznia
Copy link
Contributor

iwiznia commented Nov 14, 2022

Ah cool. I think I've seen this before. We are apparently trying to download this image https://d1wpcgnaa73g0y.cloudfront.net/825d2d6d08b35c4e47d9a7d6da678e68062f8f6c_128.jpeg which does not exist. The OG one does https://d1wpcgnaa73g0y.cloudfront.net/825d2d6d08b35c4e47d9a7d6da678e68062f8f6c.jpeg so I assume we think we created a thumbnail, but we did not. We need to figure out where this is coming from and check if we indeed should not be trying to display it OR if we are failing to generate the thumbnail in the server. If the former, this is external, if the latter then it's internal, but adding external to investigate the issue to begin with.

@iwiznia iwiznia added the External Added to denote the issue can be worked on by a contributor label Nov 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Workspace - Invite new member - 403 error message in console [$250] Workspace - Invite new member - 403 error message in console Nov 14, 2022
@alexpensify
Copy link
Contributor

@deetergp - Keep me posted if I need to create a job.

@melvin-bot melvin-bot bot added the Overdue label Nov 17, 2022
@alexpensify
Copy link
Contributor

@deetergp - any update here?

@melvin-bot melvin-bot bot removed the Overdue label Nov 17, 2022
@tylerkaraszewski tylerkaraszewski removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 17, 2022
@tylerkaraszewski tylerkaraszewski added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Nov 17, 2022
@alexpensify
Copy link
Contributor

@tylerkaraszewski - It looks like this is being moved to Internal. Keep me posted if you need anything from me to keep this moving forward. I'm OOO starting today but will check GH from time to time until I return on November 30.

@Gonals
Copy link
Contributor

Gonals commented Nov 21, 2022

While testing #12205, I went ahead and tested this too. @tylerkaraszewski, I can't reproduce this issue anymore. Are you ok with closing it?

@tylerkaraszewski
Copy link
Contributor

Let's close. It'll get reopened if someone reproduces, and if not, great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants