Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$750] Clean Up Comments in PaymentMethods.js and Remove NewDot personal bank account password field #12731

Closed
mountiny opened this issue Nov 15, 2022 · 15 comments
Assignees
Labels
Daily KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Nov 15, 2022

This has already been finished, opening this issue to track payments for C+ who has reviewed and tested this PR #12297

Previously we had this internal issue https://github.com/Expensify/Expensify/issues/233288 but we cannot assign C+ to it.

@mananjadhav What is the compensation appropriate for the PR review?

Lets also pay Mana for this issue https://github.com/Expensify/Expensify/issues/238629 and its associated PR which he has reviewed and tested.

@mananjadhav
Copy link
Collaborator

@mountiny I think 250$ is fine, this was a small PR.

But I also have this one #12175 where I put more effort in testing the workflow. Are we tracking that in a separate issue? Because that is also an internal issue but I haven't got any response yet.

@mountiny
Copy link
Contributor Author

@mananjadhav apologies for that, I thought we have gone with open contracts solution for the reviews. For any PR review/testing is you compensation part of the App issue it is linked to?

@mountiny mountiny changed the title [$250] Clean Up Comments in PaymentMethods.js#L111-L114 [$250] Clean Up Comments in PaymentMethods.js and [Polish] Remove NewDot personal bank account password field Nov 15, 2022
@mountiny mountiny changed the title [$250] Clean Up Comments in PaymentMethods.js and [Polish] Remove NewDot personal bank account password field [$250] Clean Up Comments in PaymentMethods.js and Remove NewDot personal bank account password field Nov 15, 2022
@mountiny
Copy link
Contributor Author

I have updated the PR and this issue to reflect that this will cover payment for that C+ review too

@mananjadhav
Copy link
Collaborator

I've got multiple PRs for which payment is pending but none of them have got linked issues (not atleast on the App side). Except these two I guess the others are being addressed.

@mountiny
Copy link
Contributor Author

Ok, I thought this was fleshed out better, hopefully there is not many PRs which only have Expensify repo issues.

Howe much do you reckon for the other PR?

@mananjadhav
Copy link
Collaborator

Ok, I thought this was fleshed out better, hopefully there is not many PRs which only have Expensify repo issues.

Yeah I thought so too.

Howe much do you reckon for the other PR?

I think for that one 500$ should be fine, because it required the whole Bank Account flow to be tested and it takes few rounds to test multiple scenarios.

@mountiny
Copy link
Contributor Author

@flaviadefaria Could we please create UW contract for Manan for $750 for reviewing and testing #12175 and #12297? 🙌 thanks

@mountiny mountiny changed the title [$250] Clean Up Comments in PaymentMethods.js and Remove NewDot personal bank account password field [$750] Clean Up Comments in PaymentMethods.js and Remove NewDot personal bank account password field Nov 15, 2022
@mananjadhav
Copy link
Collaborator

@flaviadefaria did you get a chance to look at this one?

@mountiny
Copy link
Contributor Author

@mananjadhav sorry, Flavia has been ooo Monday and Tuesday, should have checked that. She should be back today

@flaviadefaria
Copy link
Contributor

@flaviadefaria
Copy link
Contributor

@mananjadhav can you please apply to the job using the external link above? Thanks!

@mananjadhav
Copy link
Collaborator

thanks for the help here @flaviadefaria. I've applied now.

@flaviadefaria
Copy link
Contributor

@mananjadhav I just paid you so closing this issue.

@mananjadhav
Copy link
Collaborator

Thank you @flaviadefaria and @mountiny for helping out here. Appreciate it!

@mountiny
Copy link
Contributor Author

Whenever 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants