-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$750] Clean Up Comments in PaymentMethods.js and Remove NewDot personal bank account password field #12731
Comments
@mananjadhav apologies for that, I thought we have gone with open contracts solution for the reviews. For any PR review/testing is you compensation part of the App issue it is linked to? |
I have updated the PR and this issue to reflect that this will cover payment for that C+ review too |
I've got multiple PRs for which payment is pending but none of them have got linked issues (not atleast on the App side). Except these two I guess the others are being addressed. |
Ok, I thought this was fleshed out better, hopefully there is not many PRs which only have Expensify repo issues. Howe much do you reckon for the other PR? |
Yeah I thought so too.
I think for that one 500$ should be fine, because it required the whole Bank Account flow to be tested and it takes few rounds to test multiple scenarios. |
@flaviadefaria Could we please create UW contract for Manan for $750 for reviewing and testing #12175 and #12297? 🙌 thanks |
@flaviadefaria did you get a chance to look at this one? |
@mananjadhav sorry, Flavia has been ooo Monday and Tuesday, should have checked that. She should be back today |
Internal post - https://www.upwork.com/ab/applicants/1592815895728955392/job-details |
@mananjadhav can you please apply to the job using the external link above? Thanks! |
thanks for the help here @flaviadefaria. I've applied now. |
@mananjadhav I just paid you so closing this issue. |
Thank you @flaviadefaria and @mountiny for helping out here. Appreciate it! |
Whenever 🤗 |
This has already been finished, opening this issue to track payments for C+ who has reviewed and tested this PR #12297
Previously we had this internal issue https://github.com/Expensify/Expensify/issues/233288 but we cannot assign C+ to it.
@mananjadhav What is the compensation appropriate for the PR review?
Lets also pay Mana for this issue https://github.com/Expensify/Expensify/issues/238629 and its associated PR which he has reviewed and tested.
The text was updated successfully, but these errors were encountered: