Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-12-20] Update the wordmark to new version #13379

Closed
shawnborton opened this issue Dec 6, 2022 · 7 comments
Closed

[HOLD for payment 2022-12-20] Update the wordmark to new version #13379

shawnborton opened this issue Dec 6, 2022 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@shawnborton
Copy link
Contributor

shawnborton commented Dec 6, 2022

It looks like we're using the old wordmark still (on bottom of Sign In page), I think we forgot to add this one to our logo update.

image

Here is the correct version to use: expensify-wordmark.svg.zip

Let me know if you plan to take this one internally @grgia

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011e66cfed5ec3669d
  • Upwork Job ID: 1606447863928066048
  • Last Price Increase: 2022-12-24
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Dec 6, 2022
@grgia
Copy link
Contributor

grgia commented Dec 6, 2022

I'll whip up a PR now!

@grgia grgia added Daily KSv2 Improvement Item broken or needs improvement. Reviewing Has a PR in review labels Dec 7, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 13, 2022
@melvin-bot melvin-bot bot changed the title Update the wordmark to new version [HOLD for payment 2022-12-20] Update the wordmark to new version Dec 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 13, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 20, 2022
@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff and removed Internal Requires API changes or must be handled by Expensify staff labels Dec 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2022

Job added to Upwork: https://www.upwork.com/jobs/~011e66cfed5ec3669d

@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2022

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@mallenexpensify
Copy link
Contributor

Disregard @mananjadhav , needed to create a job to pay Sahil
@thesahindia can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~011e66cfed5ec3669d

@thesahindia
Copy link
Member

Accepted, thanks!

@mallenexpensify
Copy link
Contributor

@thesahindia paid $1000. Closing cuz I don't think we need to add a regression test step and there's not a checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants