[HOLD for regression test steps][$1000] Web - Changing room name offline doesn't reflect in LHN until another chat/room opened

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #13189

Action Performed:

1. Go to https://staging.new.expensify.com/
   and login
2. Create a room
3. Go offline
4. Go to room settings
5. Change room name
6. Click Save

Expected Result:

Room name should be updated through out the app

Actual Result:

Room name is not updated in LHN until another chat/room opened

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.37.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5855586_video_21.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b4df137e42b2ccf6
• Upwork Job ID: 1601251791178326016

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tienifr]

Proposal

Problem

In App/src/pages/home/sidebar/SidebarLinks.js
Because the chatReportSelector function doesn't update reportName and then when a reportName of the report is updated the old data and the updated data is similar so the SidebarLinks component isn't rendered

Solution

In https://github.com/tienifr/App/blob/216bbe9ff3995264e08a542d618bcc1db12d946f/src/pages/home/sidebar/SidebarLinks.js#L205

we will update the reportName and then when reportName is updated, this component will rendered again and updated the lastest information

const chatReportSelector = (report) => {
    if (ReportUtils.isIOUReport(report)) {
        return null;
    }
    return report && ({
        reportID: report.reportID,
        participants: report.participants,
        hasDraft: report.hasDraft,
        isPinned: report.isPinned,
        errorFields: {
            addWorkspaceRoom: report.errorFields && report.errorFields.addWorkspaceRoom,
        },
        maxSequenceNumber: report.maxSequenceNumber,
        lastReadSequenceNumber: report.lastReadSequenceNumber,
        lastMessageText: report.lastMessageText,
        lastActionCreated: report.lastActionCreated,
        iouReportID: report.iouReportID,
        hasOutstandingIOU: report.hasOutstandingIOU,
        statusNum: report.statusNum,
        stateNum: report.stateNum,
        chatType: report.chatType,
        policyID: report.policyID,
+        reportName: report.reportName,
    });
};

Result

Screen.Recording.2022-12-09.at.15.07.30.mov

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b4df137e42b2ccf6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

🟢 on the proposal from @tienifr. Without the report name being returned there, the LHN will never get updated when the name changes.

[mananjadhav]

Good with @tienifr's proposal.

[melvin-bot]

📣 @tienifr You have been assigned to this job by @neil-marcellini!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neil-marcellini]

It looks like this regression was introduced here d9da250. I checked out out the parent commit 15e57cd and verified that the bug did not exist at that point. I think we already have a similar regression test, so we should add this specific case.

Screen.Recording.2022-12-09.at.10.32.16.AM.mov

[tienifr]

Thanks, I've applied to the job, the PR will be ready by Dec 12

[mananjadhav]

Thanks for the update @tienifr. Let's target to get it closed by Dec 12 itself to be eligible for 50% bonus.

[neil-marcellini]

We're waiting on the fix to be deployed now.

[mallenexpensify]

Hired @tienifr and @mananjadhav can you please accept the job and reply here once you have?

[mananjadhav]

Accepted @mallenexpensify

[tienifr]

accepted, thanks @mallenexpensify

[mallenexpensify]

@tienifr and @mananjadhav paid $1500/each. Thanks for the quick fix
Leaving open cuz @zanyrenney needs to add the regression test steps, I'll try to get to this week too.

[neil-marcellini]

^ we're waiting on the regression tests. I'm commenting to remove the overdue label.

[neil-marcellini]

Same

[melvin-bot]

@mananjadhav, @neil-marcellini, @zanyrenney, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

@zanyrenney Did you get a chance to look at the above comments on pending regression steps?

[zanyrenney]

The call for the regression steps came in whilst I was OOO for the holidays (26th December). Working on this now.

[zanyrenney]

asking for a buddy check for the regression test here - https://expensify.slack.com/archives/C01SKUP7QR0/p1673376310955709?thread_ts=1673376258.732639&cid=C01SKUP7QR0

[mananjadhav]

thanks for picking this up @zanyrenney.

[zanyrenney]

Going to bump the QA channel for the regression test.

[zanyrenney]

Bumped the issue again. https://github.com/Expensify/Expensify/issues/254153

[neil-marcellini]

Looks like the regression tests were added. Have we paid everyone? If so I think we can close this.