Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-01-05 #14023

Closed
15 tasks done
OSBotify opened this issue Jan 5, 2023 · 12 comments
Closed
15 tasks done

Deploy Checklist: New Expensify 2023-01-05 #14023

OSBotify opened this issue Jan 5, 2023 · 12 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 5, 2023
@luacmartins luacmartins self-assigned this Jan 5, 2023
@luacmartins luacmartins added the Daily KSv2 label Jan 5, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 5, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Jan 5, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.49-0 🚀

@mvtglobally
Copy link

@luacmartins Regression is almost completed

#13579 is PROD QA. Ok to check it off?
#13821 (comment)
#13941 is failing #14030. It is not repro in PROD, but since its new feature from PR, we are not marking as Blocker. Please double check
#13954 (comment) We are blocked

@luacmartins
Copy link
Contributor

@luacmartins
Copy link
Contributor

Checking off #13954 (comment) since the feature is behind a beta and seems inaccessible in staging/prod.

@luacmartins
Copy link
Contributor

Just waiting on regression to finish and internal QA for #13821

@amyevans
Copy link
Contributor

amyevans commented Jan 6, 2023

Checked off #13821 as officially a pass ✅

@luacmartins
Copy link
Contributor

Nice! Now we are just waiting on regression to be done!

@mvtglobally
Copy link

@luacmartins Regression is completed. 🚀

@luacmartins
Copy link
Contributor

API timings are nominal, but I just that 2 new iOS crashes just popped up in Crashlytics in the last 20min. Taking a look now.

@mvtglobally
Copy link

mvtglobally commented Jan 6, 2023

@luacmartins we just started running a special IOS build about 30m back, not sure if this is what shows in your report #13967 (comment)

@luacmartins
Copy link
Contributor

Ah thanks for letting me know, I think that might be it since the sourcemaps don't seem to work for that crash report. I'll continue with the deploy since there was only one instance of that crash.

@luacmartins
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants