[HOLD for payment 2023-03-13] [$4000] Able to change timezone through direct link even when the automatically determine location switch is on #14340

kavimuru · 2023-01-16T22:46:34Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings > Profile
Go to Timezone
Toggle off the automatically determine location switch
Click on Timezone
Copy the URL of the select timezone page
Go back and toggle on the automatically determine location switch
In the address bar, paste the copied URL and press enter

Expected Result:

The controls should be disabled, with only the ability to go back

Actual Result:

After updating the timezone directly through the link, the new timezone is displayed on the timezone initial page, but
The old timezone is displayed on the profile page
The old timezone is selected on the timezone list page
The automatically determine location switch doesn't work

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

MacOS / Chrome / Safari

Version Number: 1.2.54-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-01-16.at.5.32.35.PM.mov

Recording.1305.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673873060216069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b8d0920a25d93b4f
Upwork Job ID: 1618711874173829120
Last Price Increase: 2023-02-09

sonialiap · 2023-01-24T00:11:27Z

I can replicate the reported behavior. Setting the timezone via the link does not update the timezone set on my profile or in the timezone selection list. Looks like making the change via the link does not override the "automatically determine toggle"

sonialiap · 2023-01-24T00:26:42Z

Asking team about expected behavior here

sonialiap · 2023-01-25T08:04:29Z

Team agreed that the behavior described here isn't ideal. Suggested solution is when Automatically determine your location then redirect https://new.expensify.com/settings/profile/timezone/select back to https://new.expensify.com/settings/profile/timezone

melvin-bot · 2023-01-26T20:46:02Z

Job added to Upwork: https://www.upwork.com/jobs/~01b8d0920a25d93b4f

melvin-bot · 2023-01-26T20:46:06Z

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-01-26T20:46:16Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

melvin-bot · 2023-01-26T20:46:20Z

Current assignee @tylerkaraszewski is eligible for the External assigner, not assigning anyone new.

Ollyws · 2023-01-26T21:07:02Z

Proposal
As suggested above we can redirect if the timezone is set to automatic:

diff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 7a89ac8ce..625ad8347 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -33,6 +33,7 @@ class TimezoneSelectPage extends Component {
 
         this.saveSelectedTimezone = this.saveSelectedTimezone.bind(this);
         this.filterShownTimezones = this.filterShownTimezones.bind(this);
+        this.isAutomaticTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone.automatic', CONST.DEFAULT_TIME_ZONE.automatic);
 
         this.currentSelectedTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone.selected', CONST.DEFAULT_TIME_ZONE.selected);
         this.allTimezones = _.chain(moment.tz.names())
@@ -55,6 +56,13 @@ class TimezoneSelectPage extends Component {
         };
     }
 
+    componentDidMount() {
+        if (!this.isAutomaticTimezone) {
+            return;
+        }
+        Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
+    }
+
     /**
      * @param {Object} timezone
      * @param {String} timezone.text

melvin-bot · 2023-01-26T21:07:06Z

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

Pujan92 · 2023-01-26T21:09:41Z

Proposal

Check the timezone automatic value and based on that navigate to initial page from constructor.

iff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 7a89ac8ce7..fe31c60405 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -34,7 +34,13 @@ class TimezoneSelectPage extends Component {
         this.saveSelectedTimezone = this.saveSelectedTimezone.bind(this);
         this.filterShownTimezones = this.filterShownTimezones.bind(this);
 
-        this.currentSelectedTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone.selected', CONST.DEFAULT_TIME_ZONE.selected);
+        const timezoneDetails = lodashGet(props.currentUserPersonalDetails, 'timezone', CONST.DEFAULT_TIME_ZONE);
+        this.currentSelectedTimezone = timezoneDetails.selected;
+
+        if (timezoneDetails.automatic) {
+            Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
+        }
+
         this.allTimezones = _.chain(moment.tz.names())

Screen.Recording.2023-01-27.at.2.41.47.AM.mp4

bernhardoj · 2023-01-27T03:21:50Z

Proposal

1st.
I think we need to replace the route so the user can't press back and land on the timezone select page.

First, we need to introduce a new parameter to the navigate function whether we want to replace the route or not. Then, just like the same thing the others done above is to check whether the timezone is set to automatic or not. If yes, we will navigate to timezone initial page with the replace set to true.

diff --git a/src/libs/Navigation/Navigation.js b/src/libs/Navigation/Navigation.js
index 3635a7840..f2d38e207 100644
--- a/src/libs/Navigation/Navigation.js
+++ b/src/libs/Navigation/Navigation.js
@@ -132,7 +132,7 @@ function isDrawerRoute(route) {
  * Main navigation method for redirecting to a route.
  * @param {String} route
  */
-function navigate(route = ROUTES.HOME) {
+function navigate(route = ROUTES.HOME, replace = false) {
     if (!canNavigate('navigate', {route})) {
         // Store intended route if the navigator is not yet available,
         // we will try again after the NavigationContainer is ready
@@ -159,7 +159,7 @@ function navigate(route = ROUTES.HOME) {
         return;
     }
 
-    linkTo(navigationRef.current, route);
+    linkTo(navigationRef.current, route, replace);
 }
 
 /**
diff --git a/src/libs/Navigation/linkTo.js b/src/libs/Navigation/linkTo.js
index 04977e6a6..3c6af3a2a 100644
--- a/src/libs/Navigation/linkTo.js
+++ b/src/libs/Navigation/linkTo.js
@@ -1,10 +1,12 @@
 import {
     getStateFromPath,
     getActionFromState,
+    StackActions,
 } from '@react-navigation/core';
 import linkingConfig from './linkingConfig';
 
-export default function linkTo(navigation, path) {
+export default function linkTo(navigation, path, replace) {
     const normalizedPath = !path.startsWith('/') ? `/${path}` : path;
     if (navigation === undefined) {
         throw new Error("Couldn't find a navigation object. Is your component inside a screen in a navigator?");
@@ -27,7 +29,11 @@ export default function linkTo(navigation, path) {
         root = current;
     }
 
-    const action = getActionFromState(state, linkingConfig.config);
+    let action = getActionFromState(state, linkingConfig.config);
+
+    if (replace) {
+        action = {...action, type: 'REPLACE'};
+    }
 
     if (action !== undefined) {
         root.dispatch(action);
diff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 7a89ac8ce..28b6b214e 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -34,7 +34,11 @@ class TimezoneSelectPage extends Component {
         this.saveSelectedTimezone = this.saveSelectedTimezone.bind(this);
         this.filterShownTimezones = this.filterShownTimezones.bind(this);
 
-        this.currentSelectedTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone.selected', CONST.DEFAULT_TIME_ZONE.selected);
+        this.currentTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone', CONST.DEFAULT_TIME_ZONE);
+        this.currentSelectedTimezone = this.currentTimezone.selected;
+        if (this.currentTimezone.automatic) {
+            Navigation.navigate(ROUTES.SETTINGS_TIMEZONE, true);
+        }
         this.allTimezones = _.chain(moment.tz.names())
             .filter(timezone => !timezone.startsWith('Etc/GMT'))
             .map(timezone => ({
@@ -82,7 +86,7 @@ class TimezoneSelectPage extends Component {
                     onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_TIMEZONE)}
                     onCloseButtonPress={() => Navigation.dismissModal(true)}
                 />
-                <OptionsSelector
+                {!this.currentTimezone.automatic && <OptionsSelector
                     textInputLabel={this.props.translate('timezonePage.timezone')}
                     value={this.state.timezoneInputText}
                     onChangeText={this.filterShownTimezones}
@@ -90,7 +94,7 @@ class TimezoneSelectPage extends Component {
                     optionHoveredStyle={styles.hoveredComponentBG}
                     sections={[{data: this.state.timezoneOptions}]}
                     shouldHaveOptionSeparator
-                />
+                />}
             </ScreenWrapper>
         );
     }

2nd.
or we can just call navigation go back before navigate.

diff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 7a89ac8ce..b4d8052db 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -34,7 +34,12 @@ class TimezoneSelectPage extends Component {
         this.saveSelectedTimezone = this.saveSelectedTimezone.bind(this);
         this.filterShownTimezones = this.filterShownTimezones.bind(this);
 
-        this.currentSelectedTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone.selected', CONST.DEFAULT_TIME_ZONE.selected);
+        this.currentTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone', CONST.DEFAULT_TIME_ZONE);
+        this.currentSelectedTimezone = this.currentTimezone.selected;
+        if (this.currentTimezone.automatic) {
+            Navigation.goBack();
+            Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
+        }
         this.allTimezones = _.chain(moment.tz.names())
             .filter(timezone => !timezone.startsWith('Etc/GMT'))
             .map(timezone => ({
@@ -74,6 +79,10 @@ class TimezoneSelectPage extends Component {
     }

I also add !this.currentTimezone.automatic to not render the page to prevent keyboard blinking as shown from the video below.

329549.t.mp4

After applying the condition, here is how it looks.

329550.t.mp4

s77rt · 2023-01-28T14:51:22Z

PreProposal

The TimezoneSelectPage component suffers from stale data issue and proposals won't work as intended.

The stale data is on currentUserPersonalDetails where if the timezone get's updated whether to be set to another timezone or switched to automatic, the page won't re-render.

Although technically this is a different issue it seems necessary to fix the reported bug. This is how I'd fix the stale data issue:

diff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 7a89ac8ce7..634e947be9 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -31,28 +31,51 @@ class TimezoneSelectPage extends Component {
     constructor(props) {
         super(props);
 
+        this.getCurrentTimezone = this.getCurrentTimezone.bind(this);
+        this.getAllTimezones = this.getAllTimezones.bind(this);
         this.saveSelectedTimezone = this.saveSelectedTimezone.bind(this);
         this.filterShownTimezones = this.filterShownTimezones.bind(this);
 
-        this.currentSelectedTimezone = lodashGet(props.currentUserPersonalDetails, 'timezone.selected', CONST.DEFAULT_TIME_ZONE.selected);
-        this.allTimezones = _.chain(moment.tz.names())
+        this.timezone = this.getCurrentTimezone();
+        this.allTimezones = this.getAllTimezones();
+
+        this.state = {
+            timezoneInputText: this.timezone.selected,
+            timezoneOptions: this.allTimezones,
+        };
+    }
+
+    componentDidUpdate(prevProps) {
+        if (lodashGet(prevProps.currentUserPersonalDetails, 'timezone') === lodashGet(this.props.currentUserPersonalDetails, 'timezone')) {
+            return;
+        }
+
+        this.timezone = this.getCurrentTimezone();
+        this.allTimezones = this.getAllTimezones();
+        this.setState({
+            timezoneInputText: this.timezone.selected,
+            timezoneOptions: this.allTimezones,
+        });
+    }
+
+    getCurrentTimezone() {
+        return lodashGet(this.props.currentUserPersonalDetails, 'timezone', CONST.DEFAULT_TIME_ZONE);
+    }
+
+    getAllTimezones() {
+        return _.chain(moment.tz.names())
             .filter(timezone => !timezone.startsWith('Etc/GMT'))
             .map(timezone => ({
                 text: timezone,
                 keyForList: timezone,
 
                 // Include the green checkmark icon to indicate the currently selected value
-                customIcon: timezone === this.currentSelectedTimezone ? greenCheckmark : undefined,
+                customIcon: timezone === this.timezone.selected ? greenCheckmark : undefined,
 
                 // This property will make the currently selected value have bold text
-                boldStyle: timezone === this.currentSelectedTimezone,
+                boldStyle: timezone === this.timezone.selected,
             }))
             .value();
-
-        this.state = {
-            timezoneInputText: this.currentSelectedTimezone,
-            timezoneOptions: this.allTimezones,
-        };
     }
 
     /**

IMPORTANT: The proposals below are based on that proposal being applied first.

NOTE: There is also another issue with OptionsList where it won't re-render if the data roughly changed since we do use shallow object comparison. The fix is to pass extraData but this will also requires changes to forward the same prop from OptionsSelector. This issue is not much noticeable because most of the time the TimezoneSelectPage component unmounts then mounts again and the flatlist will render as if it's the first time. Let's not handle this here, just wanted to mention it for now.

Proposal 1

diff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 634e947be9..0fe9581ed3 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -37,6 +37,9 @@ class TimezoneSelectPage extends Component {
         this.filterShownTimezones = this.filterShownTimezones.bind(this);
 
         this.timezone = this.getCurrentTimezone();
+        if (this.timezone.automatic) {
+            Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
+        }
         this.allTimezones = this.getAllTimezones();
 
         this.state = {
@@ -51,6 +54,9 @@ class TimezoneSelectPage extends Component {
         }
 
         this.timezone = this.getCurrentTimezone();
+        if (this.timezone.automatic) {
+            Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
+        }
         this.allTimezones = this.getAllTimezones();
         this.setState({
             timezoneInputText: this.timezone.selected,

Details

After applying the PreProposal we can just follow it with any of the above proposals

However it won't cover all the cases. One case that I have in mind is cache related where you will still get the timezones list. You can experience this issue by following those steps:

Navigate to http://localhost:8080/settings/profile/timezone
Switch off automatic timezone
Open timezone selection list
Go back using browser back button
Switch on automatic timezone
Go forward using browser forward button
If necessary go back again using browser back button
You will see the timezones list again

Kooha-2023-01-28-15-32-56.mp4

Proposal 2

diff --git a/src/libs/actions/PersonalDetails.js b/src/libs/actions/PersonalDetails.js
index 9f0247a75f..5fadb808d5 100644
--- a/src/libs/actions/PersonalDetails.js
+++ b/src/libs/actions/PersonalDetails.js
@@ -198,8 +198,7 @@ function updateAutomaticTimezone(timezone) {
 }
 
 /**
- * Updates user's 'selected' timezone, then navigates to the
- * initial Timezone page.
+ * Updates user's 'selected' timezone.
  *
  * @param {String} selectedTimezone
  */
@@ -220,7 +219,6 @@ function updateSelectedTimezone(selectedTimezone) {
             },
         }],
     });
-    Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
 }
 
 /**
diff --git a/src/pages/settings/Profile/TimezoneSelectPage.js b/src/pages/settings/Profile/TimezoneSelectPage.js
index 634e947be9..79c6844ded 100644
--- a/src/pages/settings/Profile/TimezoneSelectPage.js
+++ b/src/pages/settings/Profile/TimezoneSelectPage.js
@@ -83,7 +83,15 @@ class TimezoneSelectPage extends Component {
      * @param {String} timezone.text
      */
     saveSelectedTimezone({text}) {
-        PersonalDetails.updateSelectedTimezone(text);
+        if (this.timezone.automatic) {
+            PersonalDetails.updateAutomaticTimezone({
+                automatic: false,
+                selected: text,
+            });
+        } else {
+            PersonalDetails.updateSelectedTimezone(text);
+        }
+        Navigation.navigate(ROUTES.SETTINGS_TIMEZONE);
     }
 
     /**

Details

This proposal is based on the initially mentioned expected results.

Kooha-2023-01-28-15-40-37.mp4

Proposal 1 vs. Proposal 2

Personally, I think we should go with proposal 2 for two reasons:

It is the simplest solution to implement
If the user navigates to that URL, he is implicitly asking to set his timezone manually. Thus we should not redirect him.

fedirjh · 2023-01-30T02:45:46Z

Proposal

Expected Result:

After updating the timezone directly through the link,

So this is the expected results:

The new timezone should be displayed on the timezone initial page
The new timezone should be displayed on the profile page
The new timezone should be selected on the timezone list page
The automatically determine location switch should work

To achieve the expected results (1, 2, and 4), we should reset the automatic boolean when a new date is selected. If the automatic is set to true and the date is updated without resetting the automatic, other components will continue to use the automatic to display the date.

diff --git a/src/libs/actions/PersonalDetails.js b/src/libs/actions/PersonalDetails.js
index 9f0247a75f..d076c50e71 100644
--- a/src/libs/actions/PersonalDetails.js
+++ b/src/libs/actions/PersonalDetails.js
@@ -205,6 +205,7 @@ function updateAutomaticTimezone(timezone) {
  */
 function updateSelectedTimezone(selectedTimezone) {
     const timezone = {
+        automatic: false,
         selected: selectedTimezone,
     };
     API.write('UpdateSelectedTimezone', {

The expected result 3 : This is a separate issue that should be addressed separately.

RCA

When deep linking any page in the settings stack, the first screen displayed will become the initial screen and remain mounted until the settings modal is dismissed. This problem occurs on every screen within the settings stack. It is recommended to create a separate issue for this and hold it prior to releasing the new navigation.

Tests

These tests demonstrate that when we deep link certain pages and then click the back button, the initial page will remain mounted until we close the settings modal. I have only included a few pages to illustrate the issue, but every page within the settings modal has this problem.

Test 1 `TimezoneSelectPage`

This test demonstrates that the TimezoneSelectPage component remains mounted when the back button is pressed, but the expected result is that it should unmount upon back button press.

Screen.Recording.2023-01-30.at.3.14.35.AM.mov

Test 2 `DisplayNamePage`

The same issue applies to DisplayNamePage page. When deep linking, the component remains mounted even after clicking back.

Screen.Recording.2023-01-30.at.3.15.17.AM.mov

Test 3 : Expected result

This test displays the actual result when the tested page is not deep linked in tests 1 and 2. The components are correctly unmounted when the back button is pressed.

Screen.Recording.2023-01-30.at.3.15.50.AM.mov

mollfpr · 2023-01-30T16:10:12Z

Thank you for the proposals!

@Pujan92 ~~@bernhardoj~~ @Ollyws Your proposal is working fine, but it's only on the first try. After redirecting to the settings timezone page and pressing the go back button, then opening the direct link again, it will show the timezone select page.

@bernhardoj Thanks for noticing the keyboard visibility while redirecting to the settings timezone page! For your first proposal, I don't think we want to change anything in Navigation; it's currently on refactoring.

Also, could you explain why putting the navigation inside the constructor rather than in the componentDidMount?

For the keyboard appearance issue, we can automatically set the OptionsSelector auto-focus based on the timezone.

mollfpr · 2023-01-31T13:13:09Z

I'll reviewing @s77rt and @fedirjh proposal's some how I'm miss the proposals.

priyeshshah11 · 2023-03-22T15:21:17Z

Thanks for the payment @kevinksullivan, just wondering whether this qualifies for the bonus? As all the work by me & the review from @mollfpr was done within 3 business days, we were just waiting for @tylerkaraszewski's review for quite some time.

situchan · 2023-03-22T15:40:43Z

12k total (including C+ review and timeline bonus) is huge bounty for this issue 😮
Price keep doubled while discussing the expected behavior, and the final solution is not that complex.

Pujan92 · 2023-03-24T14:44:40Z

@priyeshshah11 @tylerkaraszewski @mollfpr @kevinksullivan Linked PR to this issue causing regression and broke the scroll to initial focused option functionality.

Screen.Recording.2023-03-24.at.8.12.52.PM.mov

Sharing possible solution

App/src/pages/settings/Profile/TimezoneSelectPage.js

Line 142 in 10d3d52

initiallyFocusedOptionKey={this.currentSelectedTimezone}

this.currentSelectedTimezone should be replaced with this.timezone.selected
App/src/pages/settings/Profile/TimezoneSelectPage.js

Lines 74 to 76 in 10d3d52

getKey(text) {

return `${text}-${(new Date()).getTime()}`;

}

I don't know why this(getKey) is required but if it remains then we need to consider text here instead of keyForList

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 159 in 10d3d52

const indexOfInitiallyFocusedOption = _.findIndex(allOptions, option => option.keyForList === this.props.initiallyFocusedOptionKey);

Screen.Recording.2023-03-24.at.8.13.09.PM.mov

MelvinBot · 2023-03-27T18:21:47Z

@tylerkaraszewski, @kevinksullivan, @mollfpr, @priyeshshah11 Huh... This is 4 days overdue. Who can take care of this?

MelvinBot · 2023-03-29T18:22:31Z

@tylerkaraszewski, @kevinksullivan, @mollfpr, @priyeshshah11 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

priyeshshah11 · 2023-03-29T19:19:16Z

Is there any action required by me?

kevinksullivan · 2023-03-31T18:06:32Z

Was just checking our policy on regressions beyond 7 days. It looks like this should still qualify for the bonus. Sent another offer to get this squared away @priyeshshah11 @mollfpr

https://www.upwork.com/jobs/~01295b5353bdb74897

priyeshshah11 · 2023-03-31T18:23:40Z

Was just checking our policy on regressions beyond 7 days. It looks like this should still qualify for the bonus. Sent another offer to get this squared away @priyeshshah11 @mollfpr

https://www.upwork.com/jobs/~01295b5353bdb74897

Thanks @kevinksullivan but the offers shows as withdrawn for me and I can't accept/apply. Could you please resend?

mollfpr · 2023-03-31T18:25:44Z

Thanks @kevinksullivan accepted!

kevinksullivan · 2023-03-31T19:02:21Z

@priyeshshah11 hm, upwork seems to be throwing an error each time I try to invite you. I'll try again.

kevinksullivan · 2023-03-31T19:03:56Z

I don't know what's going on here. It makes it seem as though it worked and then doesn't show you in the list. Want to try applying and I'll accept the proposal from there? Sorry about this @priyeshshah11

priyeshshah11 · 2023-03-31T19:18:13Z

@kevinksullivan Got the offer and accepted now! Thanks 👍

MelvinBot · 2023-04-04T09:36:55Z

@tylerkaraszewski, @kevinksullivan, @mollfpr, @priyeshshah11 Whoops! This issue is 2 days overdue. Let's get this updated quick!

tylerkaraszewski · 2023-04-04T21:54:20Z

@kevinksullivan - this issue shows as overdue but I'm not sure what action we're waiting on. A PR from @priyeshshah11 ?

kevinksullivan · 2023-04-05T01:44:07Z

Just waiting to finish payment @tylerkaraszewski

kevinksullivan · 2023-04-05T01:44:30Z

@priyeshshah11 it looks like the offer is still pending... Does it show as accepted on your end?

priyeshshah11 · 2023-04-05T07:23:49Z

@priyeshshah11 it looks like the offer is still pending... Does it show as accepted on your end?

@kevinksullivan accepted & requested payment

kevinksullivan · 2023-04-07T14:20:36Z

sheesh, sorry about all the back and forth @priyeshshah11 . It seems I finally got this to work. Closing out!

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 16, 2023

melvin-bot bot locked and limited conversation to collaborators Jan 16, 2023

melvin-bot bot assigned sonialiap Jan 16, 2023

sonialiap removed their assignment Jan 25, 2023

sonialiap added the Engineering label Jan 25, 2023

melvin-bot bot assigned tylerkaraszewski Jan 25, 2023

tylerkaraszewski added the External Added to denote the issue can be worked on by a contributor label Jan 26, 2023

melvin-bot bot unlocked this conversation Jan 26, 2023

melvin-bot bot changed the title ~~Able to change timezone through direct link even when the automatically determine location switch is on~~ [$1000] Able to change timezone through direct link even when the automatically determine location switch is on Jan 26, 2023

melvin-bot bot assigned kevinksullivan Jan 26, 2023

melvin-bot bot assigned mollfpr Jan 26, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2023

melvin-bot bot added the Overdue label Jan 28, 2023

melvin-bot bot removed the Overdue label Jan 30, 2023

melvin-bot bot added the Overdue label Mar 24, 2023

melvin-bot bot removed the Overdue label Mar 29, 2023

melvin-bot bot added the Overdue label Apr 3, 2023

melvin-bot bot removed the Overdue label Apr 4, 2023

melvin-bot bot added the Overdue label Apr 7, 2023

kevinksullivan closed this as completed Apr 7, 2023

melvin-bot bot removed the Overdue label Apr 7, 2023

This was referenced Aug 14, 2023

[Awaiting Miro Payment] [$1000] Timezone select page does not navigate back to timezone initial page after user changes timezone to automatic from another device #24516

Closed

Disable timezone list if automatic timezone is turned on #24577

Merged

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-03-13] [$4000] Able to change timezone through direct link even when the automatically determine location switch is on #14340

[HOLD for payment 2023-03-13] [$4000] Able to change timezone through direct link even when the automatically determine location switch is on #14340

kavimuru commented Jan 16, 2023 •

edited by kbecciv

Loading

sonialiap commented Jan 24, 2023

sonialiap commented Jan 24, 2023

sonialiap commented Jan 25, 2023

melvin-bot bot commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

Ollyws commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

Pujan92 commented Jan 26, 2023 •

edited

Loading

bernhardoj commented Jan 27, 2023 •

edited

Loading

s77rt commented Jan 28, 2023 •

edited

Loading

fedirjh commented Jan 30, 2023

Expected Result:

mollfpr commented Jan 30, 2023 •

edited

Loading

mollfpr commented Jan 31, 2023

priyeshshah11 commented Mar 22, 2023

situchan commented Mar 22, 2023

Pujan92 commented Mar 24, 2023 •

edited

Loading

MelvinBot commented Mar 27, 2023

MelvinBot commented Mar 29, 2023

priyeshshah11 commented Mar 29, 2023

kevinksullivan commented Mar 31, 2023

priyeshshah11 commented Mar 31, 2023

mollfpr commented Mar 31, 2023

kevinksullivan commented Mar 31, 2023

kevinksullivan commented Mar 31, 2023

priyeshshah11 commented Mar 31, 2023

MelvinBot commented Apr 4, 2023

tylerkaraszewski commented Apr 4, 2023

kevinksullivan commented Apr 5, 2023

kevinksullivan commented Apr 5, 2023

priyeshshah11 commented Apr 5, 2023

kevinksullivan commented Apr 7, 2023

[HOLD for payment 2023-03-13] [$4000] Able to change timezone through direct link even when the automatically determine location switch is on #14340

[HOLD for payment 2023-03-13] [$4000] Able to change timezone through direct link even when the automatically determine location switch is on #14340

Comments

kavimuru commented Jan 16, 2023 • edited by kbecciv Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

sonialiap commented Jan 24, 2023

sonialiap commented Jan 24, 2023

sonialiap commented Jan 25, 2023

melvin-bot bot commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

Ollyws commented Jan 26, 2023

melvin-bot bot commented Jan 26, 2023

Pujan92 commented Jan 26, 2023 • edited Loading

bernhardoj commented Jan 27, 2023 • edited Loading

Proposal

s77rt commented Jan 28, 2023 • edited Loading

PreProposal

Proposal 1

Details

Proposal 2

Details

Proposal 1 vs. Proposal 2

fedirjh commented Jan 30, 2023

Proposal

Expected Result:

The expected result 3 : This is a separate issue that should be addressed separately.

RCA

Tests

Test 1 TimezoneSelectPage

Test 2 DisplayNamePage

Test 3 : Expected result

mollfpr commented Jan 30, 2023 • edited Loading

mollfpr commented Jan 31, 2023

priyeshshah11 commented Mar 22, 2023

situchan commented Mar 22, 2023

Pujan92 commented Mar 24, 2023 • edited Loading

MelvinBot commented Mar 27, 2023

MelvinBot commented Mar 29, 2023

priyeshshah11 commented Mar 29, 2023

kevinksullivan commented Mar 31, 2023

priyeshshah11 commented Mar 31, 2023

mollfpr commented Mar 31, 2023

kevinksullivan commented Mar 31, 2023

kevinksullivan commented Mar 31, 2023

priyeshshah11 commented Mar 31, 2023

MelvinBot commented Apr 4, 2023

tylerkaraszewski commented Apr 4, 2023

kevinksullivan commented Apr 5, 2023

kevinksullivan commented Apr 5, 2023

priyeshshah11 commented Apr 5, 2023

kevinksullivan commented Apr 7, 2023

kavimuru commented Jan 16, 2023 •

edited by kbecciv

Loading

Pujan92 commented Jan 26, 2023 •

edited

Loading

bernhardoj commented Jan 27, 2023 •

edited

Loading

s77rt commented Jan 28, 2023 •

edited

Loading

Test 1 `TimezoneSelectPage`

Test 2 `DisplayNamePage`

mollfpr commented Jan 30, 2023 •

edited

Loading

Pujan92 commented Mar 24, 2023 •

edited

Loading