Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD][$2000] Connect Bank Account- Infinite spinner or blank page for app appears after back online #14362

Closed
4 tasks done
kbecciv opened this issue Jan 17, 2023 · 23 comments
Closed
4 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 17, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log i with expensifail account
  3. Go to Setting - WS - Connect Bank Account
  4. Go offline
  5. Select Plaid option
  6. Back online

Expected Result:

Infinite spinner or blank page for app is not appear after back online

Actual Result:

Infinite spinner or blank page for app appears after back online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari

Version Number: 1.2.55.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5899768_Screen_Recording_20230117_110044_Chrome.mp4
Bug5899768_Screen_Recording_20230117_112310_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01225bad74fa616f9b
  • Upwork Job ID: 1617347865539796992
  • Last Price Increase: 2023-01-30
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 17, 2023
@mateocole
Copy link

mateocole commented Jan 18, 2023

Going to have an engineer look at this and judge priority

@danieldoglas
Copy link
Contributor

This looks like something we can solve with external contributors. Adding External flag.

@melvin-bot melvin-bot bot removed the Overdue label Jan 23, 2023
@danieldoglas danieldoglas added Weekly KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Jan 23, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 23, 2023
@melvin-bot melvin-bot bot changed the title Connect Bank Account- Infinite spinner or blank page for app appears after back online [$1000] Connect Bank Account- Infinite spinner or blank page for app appears after back online Jan 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01225bad74fa616f9b

@melvin-bot
Copy link

melvin-bot bot commented Jan 23, 2023

Current assignee @mateocole is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 23, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 23, 2023

Current assignee @danieldoglas is eligible for the External assigner, not assigning anyone new.

@s77rt
Copy link
Contributor

s77rt commented Jan 23, 2023

Well at least the app won't let you continue if you are offline. Should we still fix this issue though?

@s77rt
Copy link
Contributor

s77rt commented Jan 23, 2023

I can't reproduce on mWeb (Android / Chrome). It seems hard to reproduce reliably.

@dreamcoder75
Copy link

Hello In my opinion, If your team write the clean code, this problem can be easily solved.
Let' s discuss more detail requirements if you are interested in me.

@danieldoglas
Copy link
Contributor

danieldoglas commented Jan 23, 2023

Well at least the app won't let you continue if you are offline. Should we still fix this issue though?

@s77rt Yes. If you regain access to the internet, the page should reload and show the component. We have offline checks to do that.

@danieldoglas
Copy link
Contributor

Hello In my opinion, If your team write the clean code, this problem can be easily solved. Let's discuss more detail requirements if you are interested in me.

@devJesseNorris Please read our contributing guidelines if you want to contribute.

@richard-here
Copy link

I'm not able to reproduce issue this on Android Chrome.

@situchan
Copy link
Contributor

This is not reproducible on all envs (dev/staging/production), all platforms.
Might have been fixed in #13236

@mananjadhav
Copy link
Collaborator

@kbecciv the version mentioned in the GH issue is v1.2.55.0, whereas the current version is v1.2.59-1. Can you please confirm if you're still able to reproduce this ?

@kbecciv
Copy link
Author

kbecciv commented Jan 27, 2023

@mananjadhav Checking, update you shortly

@kbecciv
Copy link
Author

kbecciv commented Jan 27, 2023

@mananjadhav Unable to reproduce the issue with build 1.2.60.0

Screen_Recording_20230127_102356_New.Expensify.mp4
Screen_Recording_20230127_102247_Chrome.mp4

@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2023
@melvin-bot melvin-bot bot changed the title [$1000] Connect Bank Account- Infinite spinner or blank page for app appears after back online [$2000] Connect Bank Account- Infinite spinner or blank page for app appears after back online Jan 30, 2023
@danieldoglas danieldoglas changed the title [$2000] Connect Bank Account- Infinite spinner or blank page for app appears after back online [HOLD][$2000] Connect Bank Account- Infinite spinner or blank page for app appears after back online Jan 30, 2023
@danieldoglas
Copy link
Contributor

Leaving this on HOLD, let's test it once more and if it doesn't happen, let's close.

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2023
@danieldoglas danieldoglas added Weekly KSv2 and removed Daily KSv2 labels Jan 30, 2023
@danieldoglas
Copy link
Contributor

@kbecciv Are you still unable to simulate this?

@kbecciv
Copy link
Author

kbecciv commented Feb 9, 2023

@danieldoglas Checking again, update you shortly.

@kbecciv
Copy link
Author

kbecciv commented Feb 9, 2023

Able to reproduced today with build 1.2.68.0

Screen_Recording_20230209_110100_Chrome.mp4

@danieldoglas
Copy link
Contributor

Hm. I've tried that on Chrome iOS and Chrome Android (simulator) and was not able to simulate it in staging.

I'll look for internal guidance on what to do in this case.

@melvin-bot melvin-bot bot added the Overdue label Feb 20, 2023
@danieldoglas danieldoglas added the Needs Reproduction Reproducible steps needed label Feb 22, 2023
@danieldoglas
Copy link
Contributor

ok, I really can't reproduce this. I'll close the issue, and let's reopen if it still hapenning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants