Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker to follow up with react-native-fast-image patch #14382

Closed
Beamanator opened this issue Jan 18, 2023 · 13 comments
Closed

Tracker to follow up with react-native-fast-image patch #14382

Beamanator opened this issue Jan 18, 2023 · 13 comments
Assignees

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Jan 18, 2023

Purpose of this issue is to regularly check on the upstream PR so we can ideally get rid of the patch-package fix we had to implement in App

@Beamanator Beamanator self-assigned this Jan 18, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 18, 2023
@trjExpensify trjExpensify changed the title Tracker to follow up with react-native-fast-image patch [HOLD Upstream fix - react-native-fast-image - #953] Tracker to follow up with react-native-fast-image patch Feb 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 20, 2023
@Beamanator
Copy link
Contributor Author

No progress on upstream PR

@cristipaval
Copy link
Contributor

Assigned myself to this one to watch a new PR open to the upstream repo, which fixes one of my issues. I also listed the new PR in the original comment of this issue.

@Expensify Expensify unlocked this conversation Mar 21, 2023
@Beamanator Beamanator changed the title [HOLD Upstream fix - react-native-fast-image - #953] Tracker to follow up with react-native-fast-image patch Tracker to follow up with react-native-fast-image patch Mar 27, 2023
@Beamanator
Copy link
Contributor Author

No movement on the linked PRs

@melvin-bot melvin-bot bot added the Overdue label May 12, 2023
@Beamanator
Copy link
Contributor Author

No movement on the linked PRs 🤷

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@cristipaval
Copy link
Contributor

Same.

@melvin-bot melvin-bot bot removed the Overdue label Jun 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@Beamanator
Copy link
Contributor Author

Still no progress - when do we close this out? 😅

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@Beamanator
Copy link
Contributor Author

No progress

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@Beamanator
Copy link
Contributor Author

I wonder when we should stop tracking these lol

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@Beamanator
Copy link
Contributor Author

same

@melvin-bot melvin-bot bot removed the Overdue label Oct 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2023
@Beamanator
Copy link
Contributor Author

same

@cristipaval
Copy link
Contributor

same

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@cristipaval
Copy link
Contributor

No progress 😞

@melvin-bot melvin-bot bot removed the Overdue label Feb 2, 2024
@cristipaval
Copy link
Contributor

I'm closing this one as it seems that we no longer use fast-image in the App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants