Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-01-31 #14709

Closed
14 tasks done
OSBotify opened this issue Jan 31, 2023 · 12 comments
Closed
14 tasks done

Deploy Checklist: New Expensify 2023-01-31 #14709

OSBotify opened this issue Jan 31, 2023 · 12 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 31, 2023 •
edited by thienlnam
Loading

Release Version: 1.2.63-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 31, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 31, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.63-0 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 1, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.63-1 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 1, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.63-1 has been deployed to staging 🎉

@mvtglobally
Copy link

Regression is almost completed

#14608 Is failing #14720

@thienlnam
Copy link
Contributor

@mvtglobally That appears to be expected from this comment #14720 (comment)

How is QA for #14463 and the rest of #14608?

@mvtglobally
Copy link

mvtglobally commented Feb 1, 2023 •
edited
Loading

#14463 - we are struggling a bit. It would help if you can run this internally (#14463 (comment))
rest of #14608 is fine

@mountiny mountiny mentioned this issue Feb 1, 2023
Closed
6 tasks
@thienlnam
Copy link
Contributor

Created another issue #14739

Going to move forward with deploy since it might have already been an issue, but does not seem like a blocker right now

@thienlnam
Copy link
Contributor

:shipit:

@OSBotify OSBotify reopened this Feb 1, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 1, 2023

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Feb 1, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 1, 2023

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@thienlnam
Copy link
Contributor

:shipit:

@thienlnam thienlnam reopened this Feb 2, 2023
@thienlnam
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thienlnam @applausebot @mvtglobally @OSBotify