Double spaces in IOU confirmation message

[youssef-lr]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Have an IOU request in the chat
2. Settle it up, either using PayPal, Elsewhere, or Wallet
3. Notice the text has double spaces, e.g. Settled up elsewhere.

Expected Result:

There shouldn't be an extra space.

Actual Result:

There is an extra space.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.2.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-02-01.at.23.46.52.mov

Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[youssef-lr]

@NicMendonca super quick fix I have a PR for ready shortly. No need for C+.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.64-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix double spaces in IOU confirmation message #14768

If no regressions arise, payment will be issued on 2023-02-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

This wasn't a major regression, just a small bug caused by an extra space!

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR: Refactor pay with wallet API #12646
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Propose regression test steps to ensure the same bug will not reach production again.: This bug doesn't need a regression test. It went unnoticed during PR reviews.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[youssef-lr]

No payment to be made as this was worked on and reviewed internally. Closing!