Account Avatar is only updated after a refresh when added/delete cross-platform (NewDot <> OldDot)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #13216

Action Performed:

1. Log in with the same account in OldDot and NewDot
2. Go to NewDot and upload a new custom avatar
3. Switch to OldDot - Setting - Account > refresh the page
4. Observe that the custom avatar doesn't update in OldDot until after a refresh
5. Delete the custom avatar in OldDot
6. Switch back to NewDot > Refresh the page
7. Observe that the custom avatar doesn't get remove in NewDot until after a refresh

Expected Result:

Adding a custom avatar in NewDot doesn't require a refresh in OldDot to show
Removing a custom avatar in OldDot doesn't require a refresh in NewDot to show

Actual Result:

Avatar is only displayed correctly after a refresh

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.63.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Avator.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

I'll jump on this on Monday, but @grgia putting it on your radar in the meantime wrt default avatars.

[MelvinBot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[trjExpensify]

I can reproduce this, just like your video, but that differs to the steps/title in the OP. The custom avatar added in NewDot isn't updated in OldDot until after a refresh, and the custom avatar removed in OldDot isn't updated in NewDot until after a refresh.

Steps I've updated in the OP are as follows:

1. Log in with the same account in OldDot and NewDot
2. Go to NewDot and upload a new custom avatar
3. Switch to OldDot - Setting - Account > refresh the page
4. Observe that the custom avatar doesn't update in OldDot until after a refresh
5. Delete the custom avatar in OldDot
6. Switch back to NewDot > refresh the page
7. Observe that the custom avatar doesn't get remove in NewDot until after a refresh

Assigning engineering for an opinion on whether this can be external, or if we need to handle this internally as it might be something related to pusher.

[tgolen]

I don't think this is a bug, it should be classified as a new feature. I think this brings up a much wider discussion of potential features... I think before we do this GH, we need to figure out:

How much should we try to keep OldDot in sync with NewDot (without requiring a refresh) in light of wanting to completely get rid of OldDot someday?

There are THOUSANDS of actions you can take in OldDot that would impact NewDot (eg. changing your name, creating policies, submitting reports, yada yada). I do not think that we want to put any effort into keeping the two in sync, since we are going to completely replace OldDot someday.

[trjExpensify]

Oh, why did I think we already kept the profile data in sync across NewDot and OldDot? 🤔

Cool, if we aren't doing that (I just checked a few fields and you're right), I'm happy to actually just close this out as a new feature request. Switching the label for posterity and closing.