[HOLD for payment 2023-04-28] Workspace VBA configured for Expensify Card should fail on "Disconnect bank account"

[PauloGasparSv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found while testing and reviewing #14869, coming from this slack thread.

Action Performed:

1. Create an account and set up a domain for it.
2. In NewDot, create a workspace for that account and create a VBA in it
3. In NewDot, Make sure you can see the VBA in the Personal Payments Method page
4. Set up that Domain and VBA you created for the Expensify Card
5. In NewDot, go to the workspace you created and delete the VBA (Settings -> Workspace -> Your Workspace -> Disconnect Bank Account)

Expected Result:

That action should fail and a RBR error should appear below the "Disconnect Bank Account" button.

Actual Result:

The action seems to succeed and goes back to the Connect Bank Account screen and a RBR error appears on the personal payment methods list (Settings -> Payments)

StrangeBug.mov

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f57d66298c0df95
• Upwork Job ID: 1623787003850874880
• Last Price Increase: 2023-02-09

[MelvinBot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010f57d66298c0df95

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[MelvinBot]

@mananjadhav, @zanyrenney, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@mananjadhav, @zanyrenney, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aldo-expensify]

I'll look into this later today, no overdue

[aldo-expensify]

I failed to get to work on it. I'll probably have time tomorrow.

[zanyrenney]

thanks for the update @aldo-expensify

[zanyrenney]

Any update @aldo-expensify ? If this isn't a top priority, we should downgrade it to a weekly task :)

[aldo-expensify]

Any update @aldo-expensify ? If this isn't a top priority, we should downgrade it to a weekly task :)

Sorry, I was OOO yesterday

Agreed, downgrading to weekly

[aldo-expensify]

Started to work on this today: #15394

I'm showing the error and clearing it. I have to do the strike-through part when the action is pending.

[aldo-expensify]

There were two PRs here. The internal one is already out, and the frontend PR is on staging now. Is that right?

Correct, I just asked Maria if they already did the QA or if the I needed to take over.

Once that's out (and after regression period), we just need to pay the C+ reviewing payment, and then complete the BZ checklist?

Yes

[joekaufmanexpensify]

Great, ty!

[aldo-expensify]

I'm taking over the QA

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.3-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Handle error in workspace's bank account page #15394

If no regressions arise, payment will be issued on 2023-04-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@joekaufmanexpensify] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/279293

[s77rt]

• The PR that introduced the bug has been identified: I'm not sure this applies here. Feels like a case that was never handled
• The offending PR has been commented on: n/a ^
• A discussion in #expensify-bugs has been started: Does this seem required in such a case @aldo-expensify?

---

Regression Test Proposal

1. OldDot: Have an account with a domain setup for it
2. NewDot: Login with that account
3. NewDot: Go to Settings > Workspaces > any workspace > Connect bank account
4. NewDot: Complete the VBBA process
5. OldDot: Set up the domain with the created VBBA for the Expensify Card
6. NewDot: Go to Settings > Workspaces > any workspace > Connect bank account
7. NewDot: Click 'Disconnect bank account' and Confirm the prompt
8. NewDot: Verify you get an error message below the 'Disconnect bank account' button
9. NewDot: Verify the VBBA is not deleted / disconnected

[aldo-expensify]

The PR that introduced the bug has been identified: I'm not sure this applies here. Feels like a case that was never handled
The offending PR has been commented on: n/a ^

👍

A discussion in #expensify-bugs has been started: Does this seem required in such a case @aldo-expensify?

I don't think that's needed. We had a discussion about this in slack when we created the gh issue.

About the test, in case it is of any use, the applause testing account applausetester+092021fish@applause.expensifail.com has this specific setup already.

[s77rt]

@aldo-expensify

About the test, in case it is of any use, the applause testing account applausetester+092021fish@applause.expensifail.com has this specific setup already.

What was the point of having the error setup (forcing bank account id to be 0) if we actually have such test accounts 😅?

[aldo-expensify]

What was the point of having the error setup (forcing bank account id to be 0) if we actually have such test accounts 😅?

hehe, I discovered that account while doing QA and.. do you have access to applause accounts?

[s77rt]

@aldo-expensify No 😁 Can we have access to those?

[aldo-expensify]

@aldo-expensify No 😁 Can we have access to those?

I don't think so... 😬 (just a guess)

[joekaufmanexpensify]

Okay, original upwork job is closed here. So going to make a new one.

[joekaufmanexpensify]

New upwork job is here: https://www.upwork.com/jobs/~01eb61e7003e8b32d2

[joekaufmanexpensify]

@s77rt offer sent for $1,000!

[s77rt]

@joekaufmanexpensify Accepted

[joekaufmanexpensify]

7 days have passed here with no regressions, so all set to issue payment!

[joekaufmanexpensify]

Linked regression test issue above. BZ checklist is now complete.

[joekaufmanexpensify]

@s77rt $1,000 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!