Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-10 #15018

Closed
9 tasks done
OSBotify opened this issue Feb 10, 2023 · 10 comments
Closed
9 tasks done

Deploy Checklist: New Expensify 2023-02-10 #15018

OSBotify opened this issue Feb 10, 2023 · 10 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 10, 2023

Release Version: 1.2.69-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 10, 2023
@mountiny mountiny self-assigned this Feb 10, 2023
@mountiny mountiny added the Daily KSv2 label Feb 10, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 10, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.69-2 🚀

@mvtglobally
Copy link

@mountiny regression is completed

PR #13916 is failing #15042
PR #14869 is failing #15045 & #15046

@mountiny
Copy link
Contributor

Thank you @mvtglobally did you test #14940 as well?

@mvtglobally
Copy link

Let me double check why I missed it

@mountiny
Copy link
Contributor

@mvtglobally any update? if we are all good there I can kick the deploy off

@mvtglobally
Copy link

@mountiny it seems to fail on Native apps. Not sure if that's expected or pulled from backend. Y
Team is logging an issue in a few.
https://user-images.githubusercontent.com/43995119/218222629-8ef05c53-b515-408a-9632-a627140d7c0c.MOV

@mountiny
Copy link
Contributor

Logged a new crash in this version here #15065

That failure is not a deployer blocker since its the same behaviour as the previous problem

@mvtglobally
Copy link

For tracking , issue #15066

@mountiny
Copy link
Contributor

Thank you, checked off the last box

@mountiny
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants