[HOLD for payment 2023-03-01] Web - Chat - Avatar image of the user appears small opening from user details page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com/
2. Log in with any account
3. Go to any conversation (Must be set non-default user avatar)
4. Go to account details page
5. Click/Tap the photo

Expected Result:

Image should appear in full screen and clicking on magnifying glass should display image clearly

Actual Result:

Image appears small and clicking on magnifying glass makes image blurry

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Web / Chrome

Version Number: 1.2.71.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Recording.1517.mp4

Bug5936515_Recording__304.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138944d7945e87030
• Upwork Job ID: 1625971751997423616
• Last Price Increase: 2023-02-15

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

@kbecciv I'm not able to reproduce this. The magnifier is showing up for me fine in Chrome. I'm going to close this but please feel free to reopen if there's something I'm missing.

[kavimuru]

@puneetlath Sorry. The bug was supposed to be about user's image is showing small. And when magnifier is clicked the image is showing pixelated. Do you need another bug or can I edit the steps?

[puneetlath]

@kavimuru feel free to update!

[marcaaron]

Is the image we are using to test this actually... small? I think they might be so this is probably Internal. There's only one personalDetails[login].avatar. We don't serve the larger image to the front end at all AFAIK.

Gonna grab this while I do some investigation.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0138944d7945e87030

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[marcaaron]

Ok actually it's way easy to fix this. The avatar url just has a _128 appended to it so we can just remove that for the preview component.

[puneetlath]

Nice! And you plan to take that yourself @marcaaron?

[marcaaron]

Yeah I got it. Done already - it's an easy one 😄

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.75-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix avatar preview size #15185

If no regressions arise, payment will be issued on 2023-03-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

📣 @MelvinBot! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif / @puneetlath / @marcaaron] The PR that introduced the bug has been identified. Link to the PR: n/a
• [@aimane-chnaif / @puneetlath / @marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@aimane-chnaif / @puneetlath / @marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@aimane-chnaif] Propose regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/265458

[puneetlath]

@aimane-chnaif can you help with finding the root cause PR?

[puneetlath]

Sent contract offer here: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/23531662

[aimane-chnaif]

I think we never removed _128 suffix at all for any full screen images in frontend.

This is what I found from history:
The feature to view avatar in full screen was added in #8483.
And then refactored avatar logic in #10235.
But still using avatar key (without _128 removal at the end) for full screen image, avatarThumbnail key for thumbnail.

So I'd say the issue existed from the beginning we implement full screen image and no offending PRs (at least on frontend).
There might be a case of backend update to return _128 image when used to return no _128 image before.

[puneetlath]

Created an issue for updating the regression test and paid @aimane-chnaif so I think we're good to go here. Thanks everyone!