[HOLD for payment 2023-03-16] Workspace- Offline mode Start over does not lead to the next step of add the bank account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #14726

Action Performed:

1. Login App
2. Navigate to Workspace > Connect bank account
3. Start the process of adding a VBA
4. Exit the flow midway
5. Navigate to Workspace > Connect bank account again
6. Once you see Continue with setup
7. Go offline mode
8. Click Start over
9. Click Ok on confirmation modal

Expected Result:

Verify that confirming the modal leads you to the Bank Account step

Actual Result:

Confirming the modal Start over does not lead to the next step of add the bank account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.71.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5936619_14726_iOS_1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0efa2dcf372664e
• Upwork Job ID: 1632700214058668032
• Last Price Increase: 2023-03-06

[MelvinBot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MariaHCD]

@miljakljajic I'd like to take a look at this because it was discovered when testing the PR I worked on

[MariaHCD]

Able to reproduce the issue, if the user is offline and resets their workspace bank account, then we show the offline page instead of showing the bank account setup step:

Screen.Recording.2023-02-14.at.4.40.42.PM.mov

Will continue to look into it

[francoisl]

@MariaHCD isn't this on purpose? The ReimbursementAccountPage uses a ReimbursementAccountLoadingIndicator here, and that component uses a FullPageOfflineBlockingView here.

[ctkochan22]

Based on the PR it doesnt' seem like it was expected behavior based on the Offline instructions in the original PR: #14726

But I don't think its a blocker though. As @francoisl pointed out exactly where the issue is I believe. Seems like an easy fix

[MariaHCD]

Ah, I'd added isLoading in the optimistic data for RestartBankAccountSetup. So that's why we're now showing the FullPageOfflineBlockingView instead of the BankAccountStep page.

https://github.com/Expensify/App/blob/main/src/libs/actions/ReimbursementAccount/resetFreePlanBankAccount.js#L50

I did that to fix this issue: #14726 (comment)

[MelvinBot]

@MariaHCD, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MariaHCD]

I've got a draft PR here: #15161. Not super sure if it's the best way to solve this so I'll take a closer look.

[MelvinBot]

@MariaHCD, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01f0efa2dcf372664e

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[MariaHCD]

The PR is in review: #15161

[miljakljajic]

Thank you, @MariaHCD. @mananjadhav I've invited you to the Upwork job so you're ready to be paid when the holding period is over. Please accept the offer!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.80-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Offline] Restarting workspace bank account setup should show the BankAccountStep #15161

If no regressions arise, payment will be issued on 2023-03-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @MariaHCD] The PR that introduced the bug has been identified. Link to the PR: The PR that introduced the bug was my own: Fix blank screen when showing the WorkspaceResetBankAccount modal #14726
• [@mananjadhav / @MariaHCD] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix blank screen when showing the WorkspaceResetBankAccount modal #14726 (comment)
• [@mananjadhav / @MariaHCD] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think we need any other steps here. This was caught during testing of my previous PR: Fix blank screen when showing the WorkspaceResetBankAccount modal #14726
• [@miljakljajic] Determine if we should create a regression test for the bug. (We already have a test for this https://expensify.testrail.io/index.php?/tests/view/3166241&group_by=cases:section_id&group_order=asc&group_id=229065)
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again: Not applicable, we already have a test for this.
• [@miljakljajic] Review the proposed regression test steps and location: NA
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: NA

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[MariaHCD]

Filled out the BZ checklist, feel free to double check me there!

[mananjadhav]

I think we're good here wrt to the checklist. I don't think we need additional regression steps for this.

@miljakljajic wdyt?

[mananjadhav]

@miljakljajic This is due for payout, can you please help here?

[miljakljajic]

Paid and contracted ended!

[mananjadhav]

Thanks @miljakljajic for the quick help.