[HOLD for payment 2023-03-13] Login - The magic code page is displayed first, followed by the successful login page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #14443

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Sign out if already signed in
3. Add an email for an existing applause account
4. Get the link with the magic code and click on it or copy and paste it in the same browser, in another tab
5. Verify that you are successfully logged in

Expected Result:

The successful login page is displayed

Actual Result:

The magic code page is displayed first, followed by the successful login page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.72.0

Reproducible in staging?: Yes

Reproducible in production?: No (new feature)

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5939323_14443_Web_no_2fa.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d8fc2ede25c6905c
• Upwork Job ID: 1626536239989067776
• Last Price Increase: 2023-02-17

[MelvinBot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d8fc2ede25c6905c

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[MelvinBot]

@johncschuster, @cristipaval, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[cristipaval]

This is in review, waiting for @deetergp's review

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display loading spinner while authenticating from validate code link #15311

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @cristipaval] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia / @cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia / @cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Propose regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cristipaval]

Hey @thesahindia ! You were right! I am working on a follow-up PR which handles the use case when the sign in with the link fails. And I see now what you were raising here. The intermediary screen still appears on devices with limited resources. The new state gets delayed. I am fixing this in the follow-up PR. This is my fault, no penalty for you. cc @johncschuster

[cristipaval]

I think this one got delayed due to ECX 🤔

[cristipaval]

Melvin, again.

[cristipaval]

Pinged @johncschuster internally. He's taking care of this today.

[johncschuster]

Upwork is being a bit of a PITA. I'm working on getting a different job put together so I can get this sorted. Standby!

[johncschuster]

Ok, Upwork is really not working for me. I've raised the question in Slack, and am also speaking to my Talent Specialist to see if I can get this fixed.

[johncschuster]

Coming back to this today 💪

[NikkiWines]

@johncschuster have we issued payment here? Can we close this out?

[johncschuster]

Ugh no. I'm still having trouble with Upwork. I'm walking through it with Dylan right now so I can get this out the door.

[johncschuster]

Well, Dylan fixed it embarrassingly fast 🤦‍♂️

Huzzah!

[johncschuster]

@thesahindia Dylan has just invited you to this job. Can you accept this invite? I'll get it paid out right away!

https://www.upwork.com/ab/applicants/1640296870359920640/job-details

[thesahindia]

Applied, thanks!

[johncschuster]

Fantastic! I've just sent the offer! Let me know when you've accepted so I can get the payment sent out.

[MelvinBot]

@johncschuster, @cristipaval, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[thesahindia]

I have accepted the offer. Thanks!

[NikkiWines]

@cristipaval @johncschuster just bumping this issue - anything further that we need to do here to get this closed out?

[cristipaval]

I think @johncschuster has to perform the payment and hen we close it out.

[cristipaval]

It looks like John is OOO. I'll ask someone else to take care of this payment.

[puneetlath]

I've paid this. Sorry for the delay @thesahindia!