DEV : App is crashing from main branch on Invite member page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > workspaces > go to any workspace
2. Press on manage members > invite
3. Page load and crash after a second or 2

Expected Result:

App should not crash in invite members page

Actual Result:

App is crashing in invite members page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.73-1
Reproducible in staging?: Repro only locally
Reproducible in production?: Repro only locally
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

app-crash.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676643050837629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5fcc16bd5b9a0cb
• Upwork Job ID: 1627530120273268736
• Last Price Increase: 2023-02-20

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bfitzexpensify]

Reproducible in staging?: Repro only locally
Reproducible in production?: Repro only locally

I can't test this, so adding internal to get confirmation this is reproducible before moving forward.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d5fcc16bd5b9a0cb

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[bfitzexpensify]

No, that's wrong, I should have added engineering instead

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

@Gonals I'm investigating since I have a recent PR that modified pronouns: #14899

[Beamanator]

In the video, the crash came from a pronoun option heThey no longer existing, and that pronoun option was only available during one of my commits in that PR - the final outcome of my PR didn't include that pronoun option, so I'm not sure how it was ever set on that account 😅

I would say we probably want to gracefully handle this situation, but still I have no idea how it happened 😅 I think the only way to force it would be to manually set your pronoun value in Onyx to an invalid value, then make sure you don't see any crashes in the app

[situchan]

From slack convo, I think we confirmed someone was manually updating and testing heThey pronoun.
Now he reverted back to real pronoun and this crash doesn't happen anymore.
So we can just close this issue.

[Beamanator]

Thanks for following through with that investigation @situchan - I agree, can close this 👍