[HOLD for payment 2023-04-20] [N7 Account Settings] Create New Contact Method page

[cristipaval]

Tracking issue: https://github.com/Expensify/Expensify/issues/182122

Detailed section of doc here: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.75ovxjptjj80

Note: This can only be implemented after AddContactMethod command has been finished - see https://github.com/Expensify/Expensify/issues/231920

Part of the bigger "Account Settings" project - https://github.com/Expensify/Expensify/issues/182122
This is part 3 of our plan, where we're breaking the process into 4 steps (see tracking issue ^)
Goals for this issue is to implement "New contact method" page & flow.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d841c63abf30eee
• Upwork Job ID: 1628003728481095680
• Last Price Increase: 2023-02-21

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~016d841c63abf30eee

[MelvinBot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[shawnborton]

@cristipaval do you need mockups or anything for this?

[cristipaval]

Nothing for now, I assigned you for credit because I will need you to review the design on the new pages

[cristipaval]

I will also add you as reviewer on the PR

[shawnborton]

Sounds good!

[cristipaval]

@shawnborton Do we have a figma with the specs for new Contact methods pages?

[cristipaval]

nvm, I found it. I know it isn't updated with the current dark theme but it helps me to see the spacing between elements

[shawnborton]

Sounds good! Happy to help review your PR too.

[MelvinBot]

This issue has not been updated in over 15 days. @shawnborton, @mananjadhav, @cristipaval eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[cristipaval]

Wait, Melvin! You cheeky robot didn't link the PR to this issue. It should have been marked with the Reviewing label.

[marcaaron]

What's the status of this one? I am looking into some cleanup and removal of the deprecatedAPI and the User_SecondaryLogin_Send command is the last thing on my list 😄

[cristipaval]

the PR is on hold atm. We're pushing to get contact details merged in order to unlock this one.

[JmillsExpensify]

Just clarifying that the PR is off hold now. What's the latest? This is one of the last items for the account settings project, I'd love to cross it off the list.

[JmillsExpensify]

In fact, that PR is pretty lively! Do you think we'll close the loop this week or next?

[JmillsExpensify]

Linked PR is merged. Looks like this issue will also close in short order.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New contact method #15330

If no regressions arise, payment will be issued on 2023-04-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[JmillsExpensify]

Looks like no contributors are on the linked PR, right? Can we go ahead and close this one?

[cristipaval]

oh yes, I can remember that Melvin failed to link the PR to the issue and that's why it wasn't automatically closed.