[HOLD for payment 2023-03-13] Dev - Sending/Requesting money throws console errors

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app -> Login in account
2. Press on FAB (Plus icon)
3. Select Send Money or request money -> Enter any amount -> Select any contact
4. Notice console error appears “ERROR Warning: Failed prop type: Invalid prop participants[0].icons[0] of type function supplied to IOUConfirmationList, expected string.”

Expected Result:

No error log should appear

Actual Result:

Error log appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.75-0
Reproducible in staging?: Occurs only in Dev
Reproducible in production?: Occurs only in Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-22.at.17.14.09.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677067911435739

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ctkochan22]

As a result of this PR: https://github.com/Expensify/App/pull/13216/files#diff-65c096044d5f69b35bcdec14c99c4fda4580759df9b1a7c36650d58eea276f1dR480

The getAvatar can return either a function or a string. In IOUModal.js we set icons with getAvatar() here. This can either be a string or a function, but in IOUConfirmPage.js and IOUConfirmationList.js we declare just the type string.

[ctkochan22]

I'll have a PR up, we just need to update the prop-types to accept both

[ctkochan22]

PR: #15464

[johncschuster]

Upwork job: https://www.upwork.com/jobs/~01f22acbdf2560dbe8

@sobitneupane / @dhairyasenjaliya can you apply when you get a moment?

[johncschuster]

@dhairyasenjaliya, I think I've just fixed the Upwork job (toggled it from private to public). Can you take a look?

[ctkochan22]

I unfortunately won't be able to complete this. I've asked @grgia to step in for now: #15464

Please unassign if you can't take this on

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update proptypes for participant.icons in IOU components #15464

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@grgia] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/13216/files#diff-65c096044d5f69b35bcdec14c99c4fda4580759df9b1a7c36650d58eea276f1dR480
• [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
• [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. - N/A I think this is unnecessary for this PR
• [@grgia] Propose regression test steps to ensure the same bug will not reach production again. - N/A I think this is unnecessary for this bug, and will be solved by testing documentation. This bug did not reach production
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[grgia]

Completed BZ checklist, I think we just need to pay out @johncschuster

[sobitneupane]

Waiting payment

cc: @johncschuster @grgia

[dhairyasenjaliya]

Hey @johncschuster I have also applied for job can you check for reporting as well

[johncschuster]

I've got you! I've just hired you both! Can you accept my invite? I'll get it sorted right now!

[sobitneupane]

@johncschuster Could not accept the offer. "This offer is not available anymore"

[johncschuster]

Wow, that is annoying. Let me investigate!

[dhairyasenjaliya]

Hey @johncschuster ping for upwork

[johncschuster]

@dhairyasenjaliya thanks for your patience! I've issued payment now.

[dhairyasenjaliya]

Received thanks @johncschuster

[sobitneupane]

@johncschuster I haven't received the payment yet.

[sobitneupane]

Bump @johncschuster @grgia for the payment