Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-22 #15389

Closed
28 tasks done
OSBotify opened this issue Feb 22, 2023 · 10 comments
Closed
28 tasks done

Deploy Checklist: New Expensify 2023-02-22 #15389

OSBotify opened this issue Feb 22, 2023 · 10 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 22, 2023

Release Version: 1.2.76-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@MelvinBot
Copy link

📣 @OSBotify! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

@MelvinBot
Copy link

📣 @MelvinBot! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@mvtglobally mvtglobally reopened this Feb 22, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 24, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.76-7 🚀

@mvtglobally
Copy link

Regression is completed

PR #14894 is failing #15415
PROD QA #15192 & #15306

We are still checking PRs
#14393
#14854
#14907
#15412

@mvtglobally
Copy link

#14907 is failing #15489
#14854 is failing #15488

@yuwenmemon
Copy link
Contributor

Good morning @mvtglobally How are we doing with the remaining PRs to be checked?

@roryabraham
Copy link
Contributor

#15224 is safe to check off since HelpDot is deployed separately from the checklist, so there's no need to HOLD this checklist on that PR.

HelpDot deploys are currently broken, so we'll just have to remember to manually check #15224 once #15361 is resolved

@mvtglobally
Copy link

@yuwenmemon everything is completed.

PR #14894 is failing #15415
PROD QA #15192 & #15306 are we ok to check off?
#14907 is failing #15489
#14854 is failing #15488

@yuwenmemon
Copy link
Contributor

PROD QA #15192 & #15306 are we ok to check off?

Yes, please do.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Feb 27, 2023
@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants