[$1000] Save button disappears for a moment after closing keyboard.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Open Settings => Profile => Personal Detail => Home Address.
3. Click on any field, then close the keyboard.
4. Notice that Save button disappears for a while after closing the keyboard.

Expected Result:

Save button shouldn’t disappear after closing the keyboard.

Actual Result:

Save button disappears for a while after closing the keyboard.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.77-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1677493900.MP4

CCYZ9037.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677494240381149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190d2982d9ddb6c16
• Upwork Job ID: 1630655300543959040
• Last Price Increase: 2023-02-28

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

I was able to reproduce this on iOS mobile web.

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Interesting! going to open up for external.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0190d2982d9ddb6c16

[MelvinBot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Current assignee @johnmlee101 is eligible for the External assigner, not assigning anyone new.

[nishchay7pixels]

I was able to replicate the issue. I confirm it is only happening on IOS and not on Android devices. Looking further into it.

[redstar504]

Possible regression of #14392 - when I remove that patch, the save button does not get hidden when toggling keyboard.

[dennismunene]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save button disappears for a while after closing the keyboard.

What is the root cause of that problem?

Setting the max height for the KeyboardAvoidingView via the "styles" prop may cause the view to disappear or flicker on certain devices.

What changes do you think we should make in order to solve the problem?

We need to use "contentContainerStyle" prop instead of the "style" prop for the KeyboardAvoidingView.

Edit this line

App/src/components/ScreenWrapper/index.js

Line 121 in c0f14f4

<KeyboardAvoidingView style={[styles.w100, styles.h100, {maxHeight: this.props.windowHeight}]} behavior={this.props.keyboardAvoidingViewBehavior}>

to this

<KeyboardAvoidingView style={[styles.w100, styles.h100]}
                               contentContainerStyle={{ maxHeight:  this.props.windowHeight }} 
                               behavior={this.props.keyboardAvoidingViewBehavior}>

Simulator.Screen.Recording.-.iPhone.14.-.2023-03-02.at.14.29.23.mp4

[MelvinBot]

📣 @dennismunene! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dennismunene]

Contributor details
Your Expensify account email: denokawawa@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017508f1bfdd7ba8d9

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[thesahindia]

It's same as #15270

Please close this one @lschurr @johnmlee101

[PankajAS]

It's same as #15270

Please close this one @lschurr @johnmlee101

this is different issue @thesahindia because its happens due to keyboard hide view and to fix this we need to push view by KeyboardAvoidingView vertical offset

[thesahindia]

@PankajAS, I don't think so. Try reverting #14392 and both will be solved.

[dennismunene]

@thesahindia won't reverting #14392 re-introduce the issues the PR was trying to fix ? What are your thoughts on my proposal as a forward fix for this?

[thesahindia]

Yes, I am not saying we should revert the PR. I am just pointing @PankajAS towards the root cause.

[johnmlee101]

Just for clarification @thesahindia this is still a dupe of #15270?

[thesahindia]

Just for clarification @thesahindia this is still a dupe of #15270?

Yeah, we can close this.

[JmillsExpensify]

Re-opening per the discussion here. cc @flodnv @mananjadhav

[flodnv]

@JmillsExpensify you forgot to reopen 😄 But honestly, maybe we leave this closed as won't fix...?