Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-04-12] [$1000] Web - Clicking "open the app in expensify" opens in desktop with already logged in acc #15651

Closed
1 of 6 tasks
kbecciv opened this issue Mar 3, 2023 · 55 comments
Closed
1 of 6 tasks

[HOLD for payment 2023-04-12] [$1000] Web - Clicking "open the app in expensify" opens in desktop with already logged in acc #15651

kbecciv opened this issue Mar 3, 2023 · 55 comments
Assignees
@ntdiary @flaviadefaria @thesahindia @hayata-suenaga
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing

Comments

@kbecciv
Copy link

kbecciv commented Mar 3, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #15262

Action Performed:

Preconditon: Desktop logged in with account A and web with Account B

  1. On web app, navigate to a user profile
  2. Refresh the browser
  3. A prompt should appear asking to 'Open the app in Electron'.
  4. Click on it and wait for the desktop app to open.

Expected Result:

Verify that app opens up correctly without any crashes.

Actual Result:

App opens in desktop with account A not with account B

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.78.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5962735_Recording__1862.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017b82df2650705ef5
  • Upwork Job ID: 1634161842563837952
  • Last Price Increase: 2023-03-10
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 3, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 3, 2023 •
edited by flaviadefaria
Loading

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mvtglobally mvtglobally mentioned this issue Mar 3, 2023
Closed
35 tasks
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2023
@flaviadefaria
Copy link
Contributor

@kbecciv it doesn't seem like this is the video that illustrates this bug, can you please check? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2023
@kbecciv
Copy link
Author

kbecciv commented Mar 9, 2023

@flaviadefaria Added correct video, sorry for confusion.

@flaviadefaria
Copy link
Contributor

Moving forward with the external label after discussing this here.

@flaviadefaria flaviadefaria added the External Added to denote the issue can be worked on by a contributor label Mar 10, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 10, 2023
@melvin-bot melvin-bot bot changed the title Web - Clicking "open the app in expensify" opens in desktop with already logged in acc [$1000] Web - Clicking "open the app in expensify" opens in desktop with already logged in acc Mar 10, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~017b82df2650705ef5

@MelvinBot
Copy link

Triggered auto assignment to @twisterdotcom (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @hayata-suenaga (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@thesahindia
Copy link
Member

@flaviadefaria, I think you mistakenly unassigned me.

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2023
@thesahindia
Copy link
Member

[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@flaviadefaria, can you please take care of this?

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 19, 2023
@s77rt s77rt mentioned this issue Apr 24, 2023
Closed
6 tasks
@MelvinBot
Copy link

@ntdiary, @zsgreenwald, @thesahindia, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thesahindia
Copy link
Member

Bump @flaviadefaria

@zsgreenwald zsgreenwald removed their assignment May 2, 2023
@MelvinBot
Copy link

@ntdiary, @thesahindia, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@flaviadefaria
Copy link
Contributor

I'm not assigned to this issue so hasn't shown up in my K2. I'm going OoO again so will reassign @zsgreenwald as he was the last assigned to this issue.

@hayata-suenaga
Copy link
Contributor

[flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@zsgreenwald, could you take care of this please?

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@ntdiary, @zsgreenwald, @thesahindia, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor

kindly bumping @zsgreenwald 🙂

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

@ntdiary, @zsgreenwald, @thesahindia, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor

kindly bumping @zsgreenwald 🙂

@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

@ntdiary, @zsgreenwald, @thesahindia, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thesahindia
Copy link
Member

@hayata-suenaga, I think we should DM @zsgreenwald.

@hayata-suenaga
Copy link
Contributor

@zsgreenwald seems to be OOO assigning someone else

@hayata-suenaga
Copy link
Contributor

@flaviadefaria I assigned you as you handled this issue previously. If you're busy, please hand this off to someone from bug zero 🙇

@flaviadefaria
Copy link
Contributor

@thesahindia just to confirm in UpWork your name is Sahil Khan, right?

@flaviadefaria
Copy link
Contributor

@ntdiary what is your name and last name in Upwork?

@ntdiary
Copy link
Contributor

ntdiary commented Jun 1, 2023

@flaviadefaria , my name is WenTao, this is my profile details: 🙂
https://www.upwork.com/freelancers/ntdiary

@thesahindia
Copy link
Member

@thesahindia just to confirm in UpWork your name is Sahil Khan, right?

Correct

@flaviadefaria
Copy link
Contributor

Alright I extended offers to @thesahindia and @ntdiary in UW.

The PR wasn't merged in 3 working days so no bonus. Payment of $1000 for each of you. Correct?

@ntdiary
Copy link
Contributor

ntdiary commented Jun 1, 2023

The PR wasn't merged in 3 working days so no bonus. Payment of $1000 for each of you. Correct?

Eh, two months ago, my memory has become a bit blurry😂. It seems that this PR was delayed for some time because a new expiration screen was added, but personally I think $1000 is quite great. 😄

@flaviadefaria
Copy link
Contributor

Awesome, issuing payment for you both right now!

@flaviadefaria
Copy link
Contributor

All done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntdiary ntdiary

@flaviadefaria flaviadefaria

@thesahindia thesahindia

@hayata-suenaga hayata-suenaga

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ntdiary @twisterdotcom @zsgreenwald @MelvinBot @flaviadefaria @thesahindia @kbecciv @hayata-suenaga