[Hold #16099] [$1000] Phone number on new phone number page is displayed with @expensify.sms

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user which has pending authentication phone number
2. Open settings
3. Open Profile
4. Open Contact Method
5. Open Phone number
6. Observe phone number displayed in text

Expected Result:

Phone number shouldn't have @expensify.sms in it

Actual Result:

Phone number is displayed with @expensify.sms in the end

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.80-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

expensify.sms.phone.number.page.issue.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678212736675549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0109f2fc4c3a9ac778
• Upwork Job ID: 1633544502312452096
• Last Price Increase: 2023-03-08

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0109f2fc4c3a9ac778

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Phone number on new phone number page is displayed with @expensify.sms

What is the root cause of that problem?

We are removing sms domain while displaying phone number as shown below:

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 173 to 175 in 7e8e8a1

	<Text>
	{this.props.translate('contacts.enterMagicCode', {contactMethod})}
	</Text>

What changes do you think we should make in order to solve the problem?

We have to remove SMS domain while displaying as shown below:

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

<Text>
    {this.props.translate('contacts.enterMagicCode', {contactMethod})} // *** OLD CODE ***
    {this.props.translate('contacts.enterMagicCode', {contactMethod: Str.removeSMSDomain(contactMethod)})} // *** NEW CODE ***
</Text>

What alternative solutions did you explore? (Optional)

None

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Phone number on new phone number page is displayed with @expensify.sms

What is the root cause of that problem?

The phone number information is retrieved from route params which contain the sms domain by default.

What changes do you think we should make in order to solve the problem?

Not sure if my proposal is considered the same as the prev proposal or not, but if we can call the method to remove the domain once then I think it would be better. I would prefer to use PersonalDetails.getDisplayName like what we did here.

Add

const contactMethodDisplayName = PersonalDetails.getDisplayName(contactMethod);

and use it in HeaderWithCloseButton title and here:

{this.props.translate('contacts.enterMagicCode', {contactMethod: contactMethodDisplayName})}

What alternative solutions did you explore? (Optional)

N/A

[MelvinBot]

📣 @wildan-m! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[puneetlath]

@mollfpr what do you think of the proposals so far?

[mollfpr]

@puneetlath It's not reproducible now because we revert the PR here #15761

[puneetlath]

Ah got it. Ok, let's close this out then. Thanks everyone!

[mollfpr]

@puneetlath This issue is resurfacing again. We should open, and I'll review the proposals above.

[puneetlath]

Argh! Reopened.

[PrashantMangukiya]

@puneetlath I think we have to go with submitted proposal, because some proposal already posted once Help wanted label applied.

[puneetlath]

Ah, that's a great point that @koko57 is redoing how phone numbers will be displayed all over the app in #16099, so it should get handled there. I'll put this on hold for that and we can look back into it after #16099 is done.

[MelvinBot]

@puneetlath, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

Still on hold.

[puneetlath]

Moving to weekly while it's on hold.

[puneetlath]

Going to go ahead and close since it is being handled by the linked issue.