-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-05] [HOLD for payment 2023-03-20] Revert splash screen logo shift regression #15770
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01e0830c07cc071b43 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane ( |
No C+ is needed here, I'm just going to revert the PR that introduced the regression. |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new. |
|
This comment was marked as outdated.
This comment was marked as outdated.
^ that was a revert PR |
Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new. |
hey @NicMendonca, could you please pay the reporting bonus to @situchan. Thanks! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-03-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
@situchan can you please apply to the job so we can issue payment? https://www.upwork.com/jobs/~01e0830c07cc071b43 Thank you! |
@NicMendonca applied! |
@situchan sorry for the delay! I just sent you the offer. |
@NicMendonca I already accepted your offer on Mar 16 |
Opps, sorry!!! Paid! 🎉 |
@NicMendonca Thanks. Can you please also close contract and cancel new offer? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-05. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Action Performed:
Expected Result:
It shifts to bottom when transitioning from splash view to our main layout
Actual Result:
It should not shift position
Platform:
Where is this issue occurring?
bug.mov
Version Number: 1.2.81-0
Reproducible in staging?: yes
Reproducible in production?: no
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678336100806819
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: