Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-05] [HOLD for payment 2023-03-20] Revert splash screen logo shift regression #15770

Closed
Julesssss opened this issue Mar 9, 2023 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Mar 9, 2023

Action Performed:

  1. Launch the app

Expected Result:

It shifts to bottom when transitioning from splash view to our main layout

Actual Result:

It should not shift position

Platform:

Where is this issue occurring?

  • Android
bug.mov

Version Number: 1.2.81-0
Reproducible in staging?: yes
Reproducible in production?: no
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678336100806819

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e0830c07cc071b43
  • Upwork Job ID: 1633771508869562368
  • Last Price Increase: 2023-03-13
@Julesssss Julesssss added DeployBlockerCash This issue or pull request should block deployment Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Mar 9, 2023
@Julesssss Julesssss self-assigned this Mar 9, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 9, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01e0830c07cc071b43

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

@Julesssss
Copy link
Contributor Author

No C+ is needed here, I'm just going to revert the PR that introduced the regression.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot unlocked this conversation Mar 9, 2023
@MelvinBot
Copy link

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 9, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Mar 10, 2023
@melvin-bot melvin-bot bot changed the title Revert splash screen logo shift regression [HOLD for payment 2023-03-17] Revert splash screen logo shift regression Mar 10, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 10, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot

This comment was marked as outdated.

@Julesssss
Copy link
Contributor Author

^ that was a revert PR

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 10, 2023
@MelvinBot
Copy link

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

@Julesssss Julesssss changed the title [$1000] Revert splash screen logo shift regression Revert splash screen logo shift regression Mar 13, 2023
@Expensify Expensify deleted a comment from MelvinBot Mar 13, 2023
@Julesssss
Copy link
Contributor Author

hey @NicMendonca, could you please pay the reporting bonus to @situchan. Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 13, 2023
@melvin-bot melvin-bot bot changed the title Revert splash screen logo shift regression [HOLD for payment 2023-03-20] Revert splash screen logo shift regression Mar 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 13, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-03-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 14, 2023
@NicMendonca
Copy link
Contributor

@situchan can you please apply to the job so we can issue payment? https://www.upwork.com/jobs/~01e0830c07cc071b43 Thank you!

@situchan
Copy link
Contributor

@NicMendonca applied!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 19, 2023
@NicMendonca
Copy link
Contributor

@situchan sorry for the delay! I just sent you the offer.

@situchan
Copy link
Contributor

@situchan sorry for the delay! I just sent you the offer.

@NicMendonca I already accepted your offer on Mar 16

@NicMendonca
Copy link
Contributor

Opps, sorry!!! Paid! 🎉

@situchan
Copy link
Contributor

@NicMendonca Thanks. Can you please also close contract and cancel new offer?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 29, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-03-20] Revert splash screen logo shift regression [HOLD for payment 2023-06-05] [HOLD for payment 2023-03-20] Revert splash screen logo shift regression May 29, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants