Unexpected label "smileysAndEmotions" instead of emoji when reacting

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. I sent a thumb up as a message
2. The other user reacted to my message giving a thumb up
3. I reacted to my own message giving a thumb up

Expected Result:

I would have expected the thumbup count to go up

Actual Result:

Label smileysAndEmotion is visible

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aldo-expensify]

If you need the Onyx data for the reportActions involved let me know

[stitesExpensify]

Slack link https://expensify.slack.com/archives/C049HHMV9SM/p1678372751210589

[stitesExpensify]

I'll be taking this on internally FYI

[stitesExpensify]

@aldo-expensify helped me test this locally and we found that the emoji object when clicked here does not have a name field, which makes it pass undefined to the served

looking into why that is happening now

[stitesExpensify]

cc @hannojg

[stitesExpensify]

Okay so the reason I can't repro locally, and that we didn't find it while testing, is that apparently some time in the past we didn't save names with frequently used.

So the solution will be:

1. Update the updateFrequentlyUsedEmoji method in PHP to make sure we are only saving with a name, and log if we are not to prevent this from happening again
2. Run a DB query to either:
   • Update all of the nvp.name = expensify_frequentlyUsedEmojis values to have the name
   • Delete all frequently used and have people start over

[stitesExpensify]

PR for part 1 is here https://github.com/Expensify/Web-Expensify/pull/36756#event-8713588729

[stitesExpensify]

This is fixed! You may need to refresh the page, or sign out and back in to see the fix