Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles #15856

Closed
1 of 6 tasks
kbecciv opened this issue Mar 10, 2023 · 76 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #15710

Action Performed:

  1. Open the app
  2. Login with any account
  3. Tap on the FAB button -> Send/Request money
  4. Quickly enter/delete numbers

Expected Result:

A second cursor doesn't "flash" after the first digit

Actual Result:

A second cursor appears after the first digit on every keyboard press

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.82.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5971828_15710_iOS.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014612000725948717
  • Upwork Job ID: 1634282958953353216
  • Last Price Increase: 2023-03-10
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@trjExpensify trjExpensify changed the title IOS - Send Money - When entering/deleting numbers quickly, the cursor doubles IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles Mar 10, 2023
@trjExpensify
Copy link
Contributor

It's reproducible, but there seems to be some history on it here: #11146. We seem to have closed that issue due to a freeze on keyboard navigation, but I don't actually think it falls under that umbrella.

Let's open this up. I understand the root cause might be upstream so that's the proposal we're probably looking for. Is that right? CC: @fedirjh @hannojg @thienlnam @Santhosh-Sellavel

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Mar 10, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 10, 2023
@melvin-bot melvin-bot bot changed the title IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles [$1000] IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles Mar 10, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~014612000725948717

@MelvinBot
Copy link

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @roryabraham (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham
Copy link
Contributor

I agree with @trjExpensify that this looks like a valid bug report. Let's get some proposals here

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2023
@narefyev91
Copy link
Contributor

Hello, I'm Nicolay from Callstack and I'm interested in taking and analysing this issue to work on a fix for it.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 13, 2023
@MelvinBot
Copy link

📣 @narefyev91 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@huzaifa-99
Copy link
Contributor

Is this issue open for proposals?

@MelvinBot
Copy link

📣 @huzaifa-99! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@huzaifa-99

This comment was marked as off-topic.

@eVoloshchak
Copy link
Contributor

@Christinadobrzyn, thanks!
Yes, looks like #26336 is a dupe of this issue, I think it can be closed

@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2023
@trjExpensify
Copy link
Contributor

Still on hold for Fabric.

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2023
@trjExpensify
Copy link
Contributor

Down to one major blocker on Fabric.

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@trjExpensify
Copy link
Contributor

Latest on Fabric: #8503 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@roryabraham
Copy link
Contributor

Still on HOLD, but we're getting closer to merging new arch

@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@trjExpensify
Copy link
Contributor

Still held, latest on Fabric here.

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@eVoloshchak
Copy link
Contributor

Update: according to #8503 (comment)

it seems plausible that switching to Fabric in Expensify is a matter of weeks / 1-2 months

@trjExpensify
Copy link
Contributor

What's the latest status on switching to Fabric? I think this follow-up issue can go in #wave-collect as polish.

@roryabraham
Copy link
Contributor

Fabric is live, taking this off HOLD

@roryabraham roryabraham changed the title [HOLD Fabric #8503][$1000] IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles [$1000] IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles Apr 15, 2024
@trjExpensify trjExpensify added Weekly KSv2 and removed Monthly KSv2 labels Apr 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2024
@trjExpensify
Copy link
Contributor

Alright, what are the next steps and who's doing them? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2024
@eVoloshchak
Copy link
Contributor

@trjExpensify, I cannot reproduce this bug anymore, the cursor looks normal

Screen.Recording.2024-05-05.at.22.39.04.mov

There's still something weird going on with the first symbol when entering numbers quickly (0:08 in the video above), is that something that needs to be fixed?

@trjExpensify
Copy link
Contributor

On a real iOS device on the latest TF (v1.4.71-0), I can't reproduce the reported bug in the OP, nor that one you mentioned just now. Anyone else on this issue have a real iOS device to try for a second opinion on that before we close it out?

@eVoloshchak
Copy link
Contributor

@trjExpensify, checked on a physical device, both bugs are not present

@trjExpensify
Copy link
Contributor

Great, so we can close this then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests