[HOLD for payment 2023-04-03] Feature Request: render the app behind the alert pop up rather than "open this link in your browser"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

Showing “open this link in your browser” page behind the alert, user has to cancel then click open this link in your browser to stay in web app

Solution:

Let the app render behind the alert. So hit cancel will remain in the web app

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678823496930569

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165e4a33daa7f0349
• Upwork Job ID: 1638179857422004224
• Last Price Increase: 2023-03-21

[gedu]

Can I take this one?

[gedu]

@puneetlath This will be for all deeplinks? or just some of them?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0165e4a33daa7f0349

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[gedu]

@puneetlath

Propopsal

Please re-state the problem that we are trying to solve in this issue.
Showing “open this link in your browser” page behind the alert, user has to cancel then click open this link in your browser to stay in web app

What is the root cause of that problem?
It uses a Regex to match the path, and when is valid it shows the redirection component and the alert.

What changes do you think we should make in order to solve the problem?
As chat on slack, I will remove the logic to show the Redirection page and UI, translations. The Alert will be shown only if the desktop app is installed

[aimane-chnaif]

The proposal looks good to me

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Render app behind alert #16383

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

@aimane-chnaif sent you a contract: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/23964605

[aimane-chnaif]

Accepted, thanks!

[puneetlath]

All paid. Thanks everyone!