[HOLD for payment 2023-04-03] [$1000] There is an extra ‘m’ in the edit comment when translated into Spanish

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chrome web and go to any chat
2. Send a message and hover the text. See that in both of the edit and delete icon , it’s written comment (Edit comment and Delete comment)
3. Now change the language to spanish
4. See that, in the edit comment ,it’s written ‘commentario’ (has one extra m) whereas in delete comment it’s written as ’comentario’. The word ‘comment’ when we translate it into spanish using google translate is ‘comentario’. Thus, to maintain consistency the comment in the edit comment should remove an extra ‘m’ in it.

Expected Result:

The ‘comment’ in the edit comment while translated into spanish should be displayed as ‘comentario’, like that of the delete comment. Both edit comment and delete comment should have the same display name in spanish

Actual Result:

The ‘comment’ in spanish in edit comment has extra ‘m’ on it which is not consistent with the delete comment text since both of these have a common word 'comment'

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.86-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

spanish-2023-03-16_16.46.09.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678965343854979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108397ce5e297b405
• Upwork Job ID: 1638329824833323008
• Last Price Increase: 2023-03-22

[MelvinBot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[CodeTheEd]

Proposal
Please re-state the problem that we are trying to solve in this issue.
There is an extra ‘m’ in the edit comment when translated into Spanish

What is the root cause of that problem?
The issue at hand is the presence of an extra 'm' in the translated Spanish edit comment.
This is caused by the use of two 'm's in the line of code that
translates to "Edit comment" in Spanish (line number 226: editComment: 'Editar commentario').

What changes do you think we should make in order to solve the problem?
To solve this problem, we propose removing one 'm' from the aforementioned line of code in the es.js file.
By making this change, the issue should be resolved.

correct (line number 226: editComment: 'Editar comentario').

[MelvinBot]

📣 @CodeTheEd! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[PrashantMangukiya]

@isabelastisser Help wanted label not applied to the issue yet, Should we post the proposal or wait for the Help Wanted label ?

[PrashantMangukiya]

According to the contribution guideline Help Wanted label is required to post the proposal, Otherwise proposal not be considered. So waiting to post the proposal until Help Wanted label applied. cc: @isabelastisser

[CodeTheEd]

Many issues are unlocked now

[PrashantMangukiya]

We can not submit proposal until the Help Wanted label applied. This is contribution guideline, otherwise proposal will not be considered.

[isabelastisser]

I was OOO, label applied now.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0108397ce5e297b405

[MelvinBot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

Triggered auto assignment to @johnmlee101 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is an extra ‘m’ in the edit comment when translated into Spanish

What is the root cause of that problem?

Its typo within es.js as shown below. i.e. extra m within 'Editar commentario'

App/src/languages/es.js

Line 227 in 0efe6ac

editComment: 'Editar commentario',

What changes do you think we should make in order to solve the problem?

Within languages/es.js we have to correct grammar as shown below:

  editComment: 'Editar comentario', 

What alternative solutions did you explore? (Optional)

None

[isabelastisser]

• I searched and can't find a dupe for this bug.

• There are some proposals for review already.

[nahidiftekhar]

Proposal to solve

Observations
The extra 'm' is only seen in 'edit comment' but not in 'delete comment'. Which effectively means that that's not a bug of the translation library rather some human error somewhere.

Investigation
Luckily the project is very well structured. So it was easy to find out how translation is handled. There is a static file that has mapping for every action context terms in Spanish with the following entries -
editComment: 'Editar commentario',
deleteComment: 'Eliminar comentario',
As you can see, here's your extra "m".

Solution
We just need to edit this above entry to this editComment: 'Editar comentario', and it should be solved.

[MelvinBot]

📣 @nahidiftekhar! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

📣 @PrashantMangukiya You have been assigned to this job by @johnmlee101!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[PrashantMangukiya]

@johnmlee101 applied for the job. Kindly accept it. So I can prepare and submit pr asap.

[ayazhussain79]

@eVoloshchak last time we discussed on slack about proposal so maybe that's why they have unlocked them so its up to the contributor if they fix something early he can post and then that issue become internal he will not get paid

[eVoloshchak]

@eVoloshchak last time we discussed on slack about proposal so maybe that's why they have unlocked them so its up to the contributor if they fix something early he can post and then that issue become internal he will not get paid

Yeah, there is a discussion in progress, but no changes as of now. There will be an official announcement and contributing guidelines will be updated

[CodeTheEd]

@eVoloshchak Sir prash has also posted before lable he was on 3rd after that he deleted it and post again it was 5am here that's why I got late for posting again, so please consider it first time

[eVoloshchak]

@eVoloshchak Sir prash has also posted before lable he was on 3rd after that he deleted it and post again

Winning proposal - is the first working proposal submitted after External or Help Wanted label has been applied.

it was 5am here that's why I got late for posting again, so please consider it first time

That would be unfair towards other contributors, the rules are public and the same for everyone

[PrashantMangukiya]

@eVoloshchak @johnmlee101 PR is ready for review.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove extra m in edit comment Spanish translation #16398

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @johnmlee101] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak / @johnmlee101] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak / @johnmlee101] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@isabelastisser] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johnmlee101]

No bug/regression from this. 792ee88

[PrashantMangukiya]

Ping for Upwork

[isabelastisser]

Issue fixed by: @PrashantMangukiya
C+ review by: @eVoloshchak

Hired in Upwork now.

I cannot find the contributor who reported this issue in Upwork @avi-shek-jha in Upwork, are they an applause tream member? I'm not sure how to process the payment, cc @johnmlee101 .

[PrashantMangukiya]

@isabelastisser offer accepted on upwork. I am also eligible for pr timeline bonus. Thank you.

[PrashantMangukiya]

@isabelastisser Payment Received. Thank you for your time.

[avi-shek-jha]

@isabelastisser Here's my upwork profile link : https://www.upwork.com/freelancers/~01a90e548bf808418c. It would be great if you could send me an invitation here

[isabelastisser]

Hey @avi-shek-jha , I hired you in Upwork. Please accept the offer and I will process the payment ASAP.

All payments were processed, all set!