[HOLD for payment 2023-03-31] [HOLD for payment 2023-03-28] Android - User is redirected to LHN instead of Concierge chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #15974

Action Performed:

1. Launch the app
2. Sign-in
3. Click on a chat not Concierge chat (to ensure your last opened chat is not Concierge)
4. Logout
5. Open https://staging.new.expensify.com/concierge
6. Sign-in the same account in step 1
7. Verify that you will be redirected to the Concierge chat (not the last opened chat)

Expected Result:

User will be redirected to the Concierge chat (not the last opened chat)

Actual Result:

User is redirected to LHN instead of Concierge chat

Workaround:

Uknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.87.0

**Reproducible in staging?:**Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

15974.Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0123826cb7fa885bf0
• Upwork Job ID: 1643688211085590528
• Last Price Increase: 2023-04-05

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

Kicking the can as I'm near-certain there's another similar issue I was looking at today, couldn't find via a quick search though

[marcochavezf]

This is an uncovered edge case from #15974 and it's fixed in this PR.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.87-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix navigation to Concierge chat after sign-up/sign-in #15788

If no regressions arise, payment will be issued on 2023-03-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mallenexpensify] Determine if we should create a regression test for the bug.
• [@marcochavezf] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@mallenexpensify] Review the proposed regression test steps and location.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix navigation to Concierge chat after sign-up/sign-in #15788

If no regressions arise, payment will be issued on 2023-03-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR: Same as in this PR, this was an uncovered case
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@mallenexpensify] Determine if we should create a regression test for this bug.
• [@marcochavezf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/272879

[marcochavezf]

Proposed regression test steps:

1. Log out if you're already logged in
2. Open https://new.expensify.com/concierge
3. Sign-up with a new account
4. Verify it navigates to the Concierge chat
5. Sign-out, close the app / refresh the browser
6. Open again https://new.expensify.com/concierge
7. Sign-in with an existing account
8. Verify again it navigates to the Concierge chat
9. Log out, don't close the app
10. Open again https://new.expensify.com/concierge
11. Sign-in with an existing account
12. Verify again it navigates to the Concierge chat

[mallenexpensify]

@thesahindia , are you due compensation? I see you did some reviewing of the PR but there wasn't a check next to your name so you weren't added to this issue.

Thanks for the regression test steps Marco, added here https://github.com/Expensify/Expensify/issues/272879

[MelvinBot]

@marcochavezf, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thesahindia]

@thesahindia , are you due compensation?

Yes, I believe I am eligible.

I see you did some reviewing of the PR but there wasn't a check next to your name so you weren't added to this issue.

I reviewed the PR but I didn't approve it because I was confused about one test case so I was waiting for an answer here.

[marcochavezf]

@thesahindia , are you due compensation? I see you did some reviewing of the PR but there wasn't a check next to your name so you weren't added to this issue.

Hi @mallenexpensify, yeah @thesahindia is eligible for compensation in that PR. There was confusion about the proposed solution, but in the end that PR was merged and reviewed.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0123826cb7fa885bf0

[MelvinBot]

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

[mallenexpensify]

Thanks @marcochavezf and @thesahindia , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0123826cb7fa885bf0

[thesahindia]

Accepted, thanks!

[mallenexpensify]

Paid, thanks @thesahindia