Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD][$250] Migrate ArrowKeyFocusManager.js to function component #16110

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 17 comments
Closed
1 task

[HOLD][$250] Migrate ArrowKeyFocusManager.js to function component #16110

marcaaron opened this issue Mar 20, 2023 · 17 comments
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate ArrowKeyFocusManager.js to function component [HOLD][$250] Migrate ArrowKeyFocusManager.js to function component Apr 13, 2023
@kuluruvineeth

This comment was marked as spam.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 29, 2023
@MelvinBot
Copy link

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 2, 2023
@MelvinBot
Copy link

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

12 days overdue now... This issue's end is nigh!

@marcaaron marcaaron removed the Daily KSv2 label May 15, 2023
@szebniok
Copy link
Contributor

Hey, I'll work on this

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 30, 2023
@roryabraham
Copy link
Contributor

roryabraham commented Jun 1, 2023

I created a useArrowKeyFocusManager hook that accomplishes the same thing as this component without including anything additional in the component hierarchy. I think it's a bit simpler to use. Maybe we should just migrate to using that rather than refactoring ArrowKeyFocusManager to a functional component.

@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I'd like to work on this issue

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@roryabraham
Copy link
Contributor

I don't really agree that we should do this. I think we should just use the useArrowKeyFocusManager hook instead.

@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@ghost
Copy link

ghost commented Jul 12, 2023

dibs?

@dexexpert
Copy link

I hope to work on this task.

@roryabraham
Copy link
Contributor

Going to close this. As stated above, this component shouldn't really be necessary in a world of functional components since we have a hook to accomplish the same thing more simply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

10 participants