Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Migrate Avatar.js to function component #16118

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 3 comments
Closed
1 task

[$250] Migrate Avatar.js to function component #16118

marcaaron opened this issue Mar 20, 2023 · 3 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

  • src/components/Avatar.js
    • type: React.PureComponent
    • has state values: true
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@techievivek techievivek self-assigned this Mar 21, 2023
@techievivek techievivek added the Weekly KSv2 label Mar 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 30, 2023
@techievivek
Copy link
Contributor

Waiting on further instructions before I actually started doing the migration.

@melvin-bot melvin-bot bot removed the Overdue label Mar 31, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate Avatar.js to function component Migrate Avatar.js to function component Apr 5, 2023
@marcaaron
Copy link
Contributor Author

@techievivek taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

  • Take it to #expensify-open-source to get clarification on.
  • Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
  • Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations
  • Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Apr 10, 2023
@marcaaron marcaaron changed the title Migrate Avatar.js to function component [$250] Migrate Avatar.js to function component Apr 13, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 3, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @techievivek eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants