Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Migrate index.js to function component #16154

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 14 comments
Closed
1 task

[$250] Migrate index.js to function component #16154

marcaaron opened this issue Mar 20, 2023 · 14 comments
Assignees
@burczu @mountiny @robertKozik
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018732ef88531525f3
  • Upwork Job ID: 1684869317224005632
  • Last Price Increase: 2023-07-28
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@s-alves10
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@burczu
Copy link
Contributor

burczu commented Jul 28, 2023

Hey, it's Bartek from Callstack - an expert contributor group - I would like to work on this issue.

@mountiny
Copy link
Contributor

Moving this to callstack for a quick work

@mountiny mountiny changed the title [HOLD][$250] Migrate index.js to function component [$250] Migrate index.js to function component Jul 28, 2023
@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Jul 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018732ef88531525f3

@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

@burczu burczu mentioned this issue Jul 31, 2023
Merged
58 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Jul 31, 2023
@burczu
Copy link
Contributor

burczu commented Jul 31, 2023

The PR is ready for review

@burczu
Copy link
Contributor

burczu commented Aug 3, 2023

PR is merged now.

@mountiny
Copy link
Contributor

mountiny commented Aug 6, 2023

Can be closed now, done and reviewed by agency engineers

@mountiny mountiny closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burczu burczu

@mountiny mountiny

@robertKozik robertKozik

Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests