Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-24] [$250] Migrate ReportActionsList.js to function component #16266

Closed
1 task done
marcaaron opened this issue Mar 20, 2023 · 14 comments
Closed
1 task done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron self-assigned this Mar 27, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 31, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate ReportActionsList.js to function component Migrate ReportActionsList.js to function component Apr 5, 2023
@marcaaron
Copy link
Contributor Author

marcaaron commented Apr 5, 2023

@marcaaron taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

  • Take it to #expensify-open-source to get clarification on.
  • Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
  • Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations
  • Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

@s77rt
Copy link
Contributor

s77rt commented Apr 13, 2023

@marcaaron Please assign me here and a BZ member for payment processing.

@marcaaron marcaaron changed the title Migrate ReportActionsList.js to function component [$250] Migrate ReportActionsList.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Apr 17, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate ReportActionsList.js to function component [HOLD for payment 2023-04-24] [$250] Migrate ReportActionsList.js to function component Apr 17, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 17, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

MelvinBot commented Apr 17, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 20, 2023
@MelvinBot
Copy link

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 20, 2023
@MelvinBot

This comment was marked as resolved.

@marcaaron marcaaron added Weekly KSv2 and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 20, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 24, 2023
@marcaaron
Copy link
Contributor Author

@greg-schroeder Added the bug label to get a BZ team member assigned. This isn't a "bug" per se, but part of an internal cleanup. We just need payment for @s77rt 🙇

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 24, 2023
@marcaaron
Copy link
Contributor Author

@greg-schroeder bump 🙏

@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2023
@greg-schroeder
Copy link
Contributor

Sorry about that, taking care of payment

@greg-schroeder
Copy link
Contributor

Sent offer @s77rt

@s77rt
Copy link
Contributor

s77rt commented Apr 27, 2023

@greg-schroeder Accepted

@greg-schroeder
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants