[HOLD for payment 2023-08-08] [$250] Migrate BasePaymentsPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f137e12ff6cd2882
• Upwork Job ID: 1676567064177229824
• Last Price Increase: 2023-07-05

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[marcaaron]

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

[multijump]

I would like to take this issue

[melvin-bot]

@aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aldo-expensify]

Oops, the PR was for another component, ignore message above. I'll try to get to this tomorrow or early next week.

[melvin-bot]

@aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aldo-expensify]

I'll get to this later during the week.

[olexyt]

Hello
I love to work on this issue.

[melvin-bot]

@aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aldo-expensify]

Started to work on this yesterday.

[stephanieelliott]

Now awaiting internal engineering review!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @multijump got assigned: 2023-07-07 04:21:08 Z
• when the PR got merged: 2023-07-28 09:39:02 UTC
• days elapsed: 15

On to the next one 🚀

[Santhosh-Sellavel]

@stephanieelliott When payment is due @Natnael-Guchima is eligible for a reporting bonus for this regression. It's being handled in this PR

Thanks!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @multijump got assigned: 2023-07-07 04:21:08 Z
• when the PR got merged: 2023-07-28 19:36:53 UTC
• days elapsed: 15

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactored BasePaymentsPage to function based component #22412
• fixed navigateToAddPaypalRoute issue #23816

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @multijump requires payment
• @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[stephanieelliott]

Summarizing payment on this issue:

• Issue reporter: $250 @Natnael-Guchima, extended offer in Upwork
• Contributor: $250 @multijump, I couldn't find you on Upwork, can you please propose to the job here?
• Contributor+: $250 @Santhosh-Sellavel, please request payment in newdot

Upwork job is here, no bonus since this was a small migration

[Natnael-Guchima]

Accepted the offer. Thanks @stephanieelliott

[multijump]

Hi, @stephanieelliott
Hope you are doing well.
I couldn't access to this job
Can you please share the public job url?
And origin upwork job doesn't exist anymore.
Thanks.

[Santhosh-Sellavel]

Requested on ND

[MonilBhavsar]

@stephanieelliott could you please take a look at @multijump's issue. We can close it the issue then

[stephanieelliott]

Hey @multijump try this link: https://www.upwork.com/jobs/~013ebab8a106d7ab8f

Otherwise, if you let me know your name on Upwork I can invite you to the job!

@Natnael-Guchima has been paid!

[multijump]

https://www.upwork.com/jobs/~013ebab8a106d7ab8f

Hi, @stephanieelliott
My name is the Oleh Koziar.
And I applied to above job.
Thanks.

[JmillsExpensify]

Review the details for @Santhosh-Sellavel. Approved for payment in NewDot based on the summary from BZ above.

[stephanieelliott]

All paid!